-
-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inverted rflink cover #26038
Inverted rflink cover #26038
Conversation
Newkaku cover defaults to InvertedRflinkCover
…changed during a search and replace
I can't figure out yet why CI (Tests PyTest Python36) and CI (FullCheck Pylint) are failing. |
Seems related with some merged code from |
@javicalle , are my tests failing because of #26187? I also noticed that the Pylint test fails when setting up the environment.
Is this something I can/should fix or should I commit a change to trigger the tests again? |
Also may be related with some code merged from dev branch.
What I would try is to review the 'files' that fail, see if there are
changes in the dev branch, make the merge only of those changes and commit
from my branch to force the execution of the tests.
I'm sorry not being able to help more.
El dom., 25 ago. 2019 14:25, fmartens <notifications@github.com> escribió:
… @javicalle <https://github.com/javicalle> , are my tests failing because
of #26187 <#26187>?
I also noticed that the Pylint test fails when setting up the environment.
ERROR: Could not find a version that satisfies the requirement bimmer_connected==0.5.6 (from -r requirements_all.txt (line 269)) (from versions: 0.0.1, 0.0.3, 0.0.4, 0.1.0, 0.2.0, 0.3.0, 0.4.0.dev0, 0.4.0, 0.4.1, 0.5.0, 0.5.1, 0.5.2, 0.5.3, 0.5.9b0, 0.5.9b1)
ERROR: No matching distribution found for bimmer_connected==0.5.6 (from -r requirements_all.txt (line 269)))
Is this something I can/should fix or should I commit a change to trigger
the tests again?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#26038>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AHUEP7MHGMYLAE2WMZTLFHDQGJ22HANCNFSM4IMRS4XQ>
.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
@javicalle , thanks for all the support. |
…into improve-bluetooth-tracker * 'dev' of https://github.com/home-assistant/home-assistant: (229 commits) New template sensor attributes (home-assistant#26127) Add BeeWi SmartClim BLE sensors (home-assistant#26174) UniFi - Simplify getting controller from config entry (home-assistant#26335) Inverted rflink cover (home-assistant#26038) Upgrade tibber library (home-assistant#26332) Migrate Axis, deCONZ and UniFi to use config entry subclass (home-assistant#26173) Upgrade sqlalchemy to 1.3.8 (home-assistant#26331) Change evohome to asyncio client (home-assistant#26042) Add support for Supla switches (home-assistant#26188) Add a keypress service for AlarmDecoder (home-assistant#26100) Fix google_maps scan interval (home-assistant#26328) Upgrade youtube_dl to 2019.09.01 (home-assistant#26330) Fix onvif camera setup error (home-assistant#24585) UniFi - use entity registry disabled_by to control available entities (home-assistant#26141) Fetch Onkyo current radio preset (home-assistant#26211) Add precision argument to the Range Filter (home-assistant#25874) Fix alexa bad temp sensors (home-assistant#26307) deCONZ - Dont update entry if data is equal Add Withings support (home-assistant#25154) Add support for Homekit accessory battery sensors (home-assistant#26210) ...
Breaking Change:
The configuration has to be updated when KAKU (newkaku) ASUN-650 covers are used. The 'type' property has to be specified and set to 'standard' when these devices have been wired 'the other way around'.
Description:
A class named InvertedRflinkCover has been added that inverts the commands to the KAKU (COCO) ASUN-650 devices. Also a property named 'type' has been added to the RflinkCover class that allows 2 values: 'standard' and 'inverted'. The InvertedRflinkCover class is used when:
Related issue (if applicable): fixes #10810
Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#10177
Example entry for
configuration.yaml
(if applicable):Checklist:
tox
. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
python3 -m script.hassfest
.requirements_all.txt
by runningpython3 -m script.gen_requirements_all
..coveragerc
.If the code does not interact with devices: