Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting for types of locations sent to a server #2015

Merged
merged 9 commits into from Dec 20, 2021

Conversation

zacwest
Copy link
Member

@zacwest zacwest commented Dec 19, 2021

Requires home-assistant/core#62243.

Summary

Allows sending exact locations (current behavior, gps coordinates), no locations (sets the device tracker to 'unknown' effectively), and zone-only locations (we send home, other_zone_name or not_home only).

Screenshots

Thing Light Dark
Setting Simulator Screen Shot - iPhone 13 Pro (15 2) - 2021-12-20 at 13 55 29 Simulator Screen Shot - iPhone 13 Pro (15 2) - 2021-12-20 at 13 55 30
New Enough Simulator Screen Shot - iPhone 13 Pro (15 2) - 2021-12-19 at 14 04 41 Simulator Screen Shot - iPhone 13 Pro (15 2) - 2021-12-19 at 14 04 43
Too Old Simulator Screen Shot - iPhone 13 Pro (15 2) - 2021-12-19 at 14 06 08 Simulator Screen Shot - iPhone 13 Pro (15 2) - 2021-12-19 at 14 06 09

Link to pull request in Documentation repository

Documentation: home-assistant/companion.home-assistant#639

@codecov
Copy link

codecov bot commented Dec 20, 2021

Codecov Report

Merging #2015 (6b788c8) into master (d3ecdd7) will decrease coverage by 0.09%.
The diff coverage is 34.17%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2015      +/-   ##
==========================================
- Coverage   29.11%   29.02%   -0.10%     
==========================================
  Files         267      267              
  Lines       21018    21064      +46     
==========================================
- Hits         6119     6113       -6     
- Misses      14899    14951      +52     
Impacted Files Coverage Δ
.../Connection/ConnectionSettingsViewController.swift 0.00% <0.00%> (ø)
Sources/Shared/API/HAAPI.swift 16.36% <0.00%> (-0.12%) ⬇️
Sources/Shared/Environment/Constants.swift 62.33% <0.00%> (-1.67%) ⬇️
Sources/Shared/API/Server.swift 81.30% <17.64%> (-12.24%) ⬇️
Sources/Shared/API/Models/RealmZone.swift 58.56% <28.57%> (-2.52%) ⬇️
...rces/Shared/API/Models/WebhookUpdateLocation.swift 84.61% <82.14%> (-2.06%) ⬇️
...es/Shared/API/Webhook/Sensors/GeocoderSensor.swift 79.38% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3ecdd7...6b788c8. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants