Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CarPlay message while entities are getting filtered #2544

Merged
merged 1 commit into from
Jan 25, 2024
Merged

Update CarPlay message while entities are getting filtered #2544

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion Sources/App/Resources/en.lproj/Localizable.strings
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@
"carPlay.navigation.tab.actions" = "Actions";
"carPlay.navigation.tab.areas" = "Areas";
"carPlay.navigation.tab.domains" = "Control";
"carPlay.state.loading.title" = "Loading...";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use … - it looks nicer

"carPlay.no_actions.title" = "Open iOS Companion App to create actions for CarPlay.";
"carPlay.no_entities.title" = "No CarPlay compatible entities available.";
"carPlay.notification.action.intro.body" = "Tap to create your first iOS Action";
Expand Down Expand Up @@ -816,4 +817,4 @@ Home Assistant is free and open source home automation software with a focus on
"widgets.open_page.description" = "Open a frontend page in Home Assistant.";
"widgets.open_page.not_configured" = "No Pages Available";
"widgets.open_page.title" = "Open Page";
"yes_label" = "Yes";
"yes_label" = "Yes";
6 changes: 6 additions & 0 deletions Sources/Shared/Resources/Swiftgen/Strings.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,6 +298,12 @@ public enum L10n {
}
}
}
public enum State {
public enum Loading {
/// Loading...
public static var title: String { return L10n.tr("Localizable", "carPlay.state.loading.title") }
}
}
public enum Unlock {
public enum Confirmation {
/// Are you sure you want to perform unlock action on %@?
Expand Down
2 changes: 1 addition & 1 deletion Sources/Vehicle/Templates/Entities/CarPlayEntitiesListTemplate.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
self.viewModel = viewModel

viewModel.templateProvider = self
paginatedListTemplate.template.emptyViewSubtitleVariants = [L10n.CarPlay.NoEntities.title]
paginatedListTemplate.template.emptyViewSubtitleVariants = [L10n.CarPlay.State.Loading.title]

Check warning on line 29 in Sources/Vehicle/Templates/Entities/CarPlayEntitiesListTemplate.swift

View check run for this annotation

Codecov / codecov/patch

Sources/Vehicle/Templates/Entities/CarPlayEntitiesListTemplate.swift#L29 

Added line #L29 was not covered by tests
}

func templateWillDisappear(template: CPTemplate) {
Expand Down