Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CarPlay message while entities are getting filtered #2544

Merged
merged 1 commit into from Jan 25, 2024

Conversation

bgoncal
Copy link
Member

@bgoncal bgoncal commented Jan 25, 2024

Summary

Screenshots

Link to pull request in Documentation repository

Documentation: home-assistant/companion.home-assistant#

Any other notes

@bgoncal bgoncal requested a review from zacwest January 25, 2024 10:41
@bgoncal bgoncal self-assigned this Jan 25, 2024
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

Attention: 105 lines in your changes are missing coverage. Please review.

Comparison is base (cef9934) 27.54% compared to head (fc16e47) 27.60%.
Report is 4 commits behind head on master.

Files Patch % Lines
Sources/App/Settings/ActionConfigurator.swift 0.00% 29 Missing ⚠️
Sources/App/Scenes/WindowSizeObserver.swift 36.11% 23 Missing ⚠️
Sources/App/Scenes/WindowScenesManager.swift 65.51% 20 Missing ⚠️
Sources/Shared/API/Models/Action.swift 11.11% 16 Missing ⚠️
...hared/Common/Extensions/Realm+Initialization.swift 0.00% 9 Missing ⚠️
Sources/App/Scenes/WebViewSceneDelegate.swift 50.00% 4 Missing ⚠️
Sources/Shared/API/Responses/MobileAppConfig.swift 0.00% 2 Missing ⚠️
...le/Templates/Actions/CarPlayActionsViewModel.swift 0.00% 1 Missing ⚠️
...mplates/Entities/CarPlayEntitiesListTemplate.swift 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2544      +/-   ##
==========================================
+ Coverage   27.54%   27.60%   +0.06%     
==========================================
  Files         309      311       +2     
  Lines       31472    31628     +156     
==========================================
+ Hits         8668     8731      +63     
- Misses      22804    22897      +93     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bgoncal bgoncal merged commit e189622 into master Jan 25, 2024
8 checks passed
@bgoncal bgoncal deleted the carplay-loading-message branch January 25, 2024 15:38
@@ -61,6 +61,7 @@
"carPlay.navigation.tab.actions" = "Actions";
"carPlay.navigation.tab.areas" = "Areas";
"carPlay.navigation.tab.domains" = "Control";
"carPlay.state.loading.title" = "Loading...";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use … - it looks nicer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants