Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when closing the macos app from full screen #2567

Merged
merged 3 commits into from Feb 12, 2024

Conversation

bgoncal
Copy link
Member

@bgoncal bgoncal commented Feb 1, 2024

Summary

Strong reference was causing a crash when closing macos app from full screen.

Screenshots

Link to pull request in Documentation repository

Documentation: home-assistant/companion.home-assistant#

Any other notes

@bgoncal bgoncal requested a review from zacwest February 1, 2024 10:31
@bgoncal bgoncal self-assigned this Feb 1, 2024
@bgoncal bgoncal linked an issue Feb 1, 2024 that may be closed by this pull request
Copy link

codecov bot commented Feb 1, 2024

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (498f279) 27.54% compared to head (4e3040c) 27.53%.
Report is 1 commits behind head on master.

Files Patch % Lines
Sources/App/Scenes/WebViewSceneDelegate.swift 0.00% 5 Missing ⚠️
Sources/App/Scenes/WindowScenesManager.swift 54.54% 5 Missing ⚠️
Sources/App/Scenes/WindowSizeObserver.swift 33.33% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2567      +/-   ##
==========================================
- Coverage   27.54%   27.53%   -0.01%     
==========================================
  Files         311      311              
  Lines       31681    31699      +18     
==========================================
+ Hits         8725     8727       +2     
- Misses      22956    22972      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sources/App/Scenes/WindowSizeObserver.swift Outdated Show resolved Hide resolved
@bgoncal bgoncal merged commit 4cc467a into master Feb 12, 2024
8 checks passed
@bgoncal bgoncal deleted the fix-crash-mac-fullscreen branch February 12, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App is crashing upon closing the app from fullscreen
2 participants