Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash when closing the macos app from full screen #2567

Merged
merged 3 commits into from
Feb 12, 2024
Merged

Fix crash when closing the macos app from full screen #2567

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
708533a
Fix crash when closing the macos app from full screen
bgoncal Feb 1, 2024
d0d8419
Update logic to explicit invalidate token
bgoncal Feb 8, 2024
4e3040c
Merge branch 'master' into fix-crash-mac-fullscreen
bgoncal Feb 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 4 additions & 3 deletions Sources/App/Scenes/WindowSizeObserver.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,17 @@
import Foundation
import Shared
import UIKit

final class WindowSizeObserver: NSObject {
@objc private(set) var observedScene: UIWindowScene?
private var observation: NSKeyValueObservation?
private weak var observation: NSKeyValueObservation?
bgoncal marked this conversation as resolved.
Show resolved Hide resolved

init(windowScene: UIWindowScene) {
self.observedScene = windowScene
super.init()
#if targetEnvironment(macCatalyst)

guard Current.isCatalyst else { return }
startObserving()
#endif
}

private func startObserving() {
Expand Down