Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weakly link ThreadFramework #2575

Merged
merged 3 commits into from Feb 8, 2024
Merged

Weakly link ThreadFramework #2575

merged 3 commits into from Feb 8, 2024

Conversation

bgoncal
Copy link
Member

@bgoncal bgoncal commented Feb 6, 2024

Summary

Preventing crash on older OS by weakly link ThreadNetwork

Screenshots

Link to pull request in Documentation repository

Documentation: home-assistant/companion.home-assistant#

Any other notes

@bgoncal bgoncal requested a review from zacwest February 6, 2024 16:45
@bgoncal bgoncal self-assigned this Feb 6, 2024
@bgoncal bgoncal changed the title Weakly import ThreadFramework Weakly link ThreadFramework Feb 6, 2024
Copy link

codecov bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3ebd1e6) 27.54% compared to head (fa536ae) 27.55%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2575      +/-   ##
==========================================
+ Coverage   27.54%   27.55%   +0.01%     
==========================================
  Files         311      311              
  Lines       31681    31681              
==========================================
+ Hits         8725     8731       +6     
+ Misses      22956    22950       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bgoncal bgoncal merged commit 9e8d337 into master Feb 8, 2024
8 checks passed
@bgoncal bgoncal deleted the weak-import-thread branch February 8, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to 2024.1: App won't start, ThreadNetwork Library missing (Monterey)
2 participants