[EN] Add half an hour/minute for timers

[synesthesiam]

Adds support for sentences like "start a timer for 1 and a half hours" and "start a timer for 3 and a half minutes"

Summary by CodeRabbit

• New Features

  • Enhanced timer duration input to support natural language patterns like "half an hour" or "a minute and a half".
  • Introduced new time unit "half" for more intuitive timer settings.

• Tests

  • Added test cases for new timer settings such as 5.5 minutes, half a minute, 1.5 hours, and half an hour.

[coderabbitai]

Walkthrough

Walkthrough

The recent changes enhance the natural language processing capabilities for setting timers. Now, the system can interpret flexible time expressions like "half an hour" or "a minute and a half", beyond the rigid minute or hour-specific inputs. This involves modifications to the timer duration handling and the inclusion of new tests for varied time formats in Home Assistant's HassStartTimer intent.

Changes

Files	Change Summary
sentences/en/_common.yaml	Improved timer_duration_minutes and timer_duration_hours to support flexible expressions. Added timer_half for handling "half".
tests/en/homeassistant_HassStartTimer.yaml	Added tests for new timer durations: half a minute, 5.5 minutes, 1.5 hours, and half an hour in the Living Room context.

---

Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE

Commits

Files that changed from the base of the PR and between 1e363d8 and 4b1d8c4.

Files selected for processing (2)

• sentences/en/_common.yaml (2 hunks)
• tests/en/homeassistant_HassStartTimer.yaml (1 hunks)

Additional comments not posted (6)

tests/en/homeassistant_HassStartTimer.yaml (4)

18-27: Added support for a timer with fractional minutes:

The addition of a test case for "5 and a half minutes" is a good implementation of the PR's objective to handle more natural language expressions for timers. This test ensures that the intent correctly captures 5 minutes and 30 seconds as separate components, which aligns with the new functionality.

---

29-37: Added support for a timer with half a minute duration:

This test case for setting a timer for "half a minute" correctly captures 30 seconds in the slots, which is a straightforward and effective way to handle fractional minute inputs. This aligns well with the PR's objective and enhances the system's usability.

---

39-48: Added support for a timer with fractional hours:

The test for "1 and a half hours" which converts to 1 hour and 30 minutes in the slots is another excellent addition. This test case ensures that the system can handle fractional hours effectively, which is crucial for the natural language processing enhancements described in the PR.

---

50-58: Added support for a timer with half an hour duration:

The inclusion of a test case for "half an hour" which translates to 30 minutes in the slots is consistent with the PR's enhancements. This test ensures that the system can interpret and act on more colloquial time expressions, improving user interaction.

sentences/en/_common.yaml (2)

352-355: New entity addition for handling 'half' as a time unit:

The introduction of the timer_half entity is an essential addition for supporting expressions like "half an hour" or "half a minute." This entity helps in translating these colloquial terms into a numerical representation (30 seconds or minutes), which is crucial for the timer functionality.

---

393-394: Updated timer duration entities to support new formats:

The updates to timer_duration_minutes and timer_duration_hours are well-implemented. They now support a variety of formats including those with fractional parts, which is key to achieving the PR's goal of enhancing natural language understanding for timer settings. This will significantly improve the user's experience by allowing more flexible voice commands.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[tetele]

The extra list seems a bit excessive. I've tackled this particular use case a long time ago with a much simplified version https://github.com/tetele/custom_sentences/blob/main/config/custom_sentences/en/delay_action.yaml