Move Docker configuration to daemon.json #2116
Conversation
This is more readable than passing arguments to the daemon directly. It also shortens the ExecStart command significantly, which is stored in every log entry in systemd-journald.
|
should we cleanup the overlay on the OTA? |
We still need the key.json, it is now just explicitly referenced (see |
|
Without bind mount, I think new installation or reseted overlay will not have that folder on the overlay. So maybe |
Right, but in tests it seems that the Docker daemon automatically creates the directory.
We would need to migrate from the overlay location. I know that its not nice that we point into the overlay directly, but it seems the simplest solution. The key file will become unnecessary in the future: |
This is more readable than passing arguments to the daemon directly. It also shortens the ExecStart command significantly, which is stored in every log entry in systemd-journald.
Since /etc/docker does not get bind mounted anymore (see home-assistant#2116), key.json from the overlay partition is used directly.
* Fix Docker key.json corruption check Since /etc/docker does not get bind mounted anymore (see #2116), key.json from the overlay partition is used directly. * Use -e flag for jq to get useful exit code
* Fix Docker key.json corruption check Since /etc/docker does not get bind mounted anymore (see #2116), key.json from the overlay partition is used directly. * Use -e flag for jq to get useful exit code
|
Are end users able to get write access or the ability to override/supersede the default settings provided in this file? A (admittedly small) users have already commented on #2135 who need this ability, mostly to set their own default base network. |
This is more readable than passing arguments to the daemon directly. It also shortens the ExecStart command significantly, which is stored in every log entry in systemd-journald.