This repository has been archived by the owner on Sep 28, 2022. It is now read-only.
Add SetDocumentationSection plugin #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balloob
reviewed
Feb 15, 2021
|
|
||
| let labels = (await Promise.all( | ||
| foundSections.map(async (section) => { | ||
| const exist = await context.github.issues.getLabel( |
There was a problem hiding this comment.
Why do we have to check if the label exists? they are created on the fly if I recall correctly from the labelbot.
There was a problem hiding this comment.
To keep some sort of control on the labels
There was a problem hiding this comment.
in this case, it is based on user input. We don't want invalid user input to create a bunch of random labels.
balloob
approved these changes
Feb 15, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract sections from labels in the issue, and apply labels to it if the label exsist.