Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bind mounting and remove on create failure #4274

Merged
merged 2 commits into from
May 2, 2023
Merged

Conversation

mdegat01
Copy link
Contributor

@mdegat01 mdegat01 commented May 1, 2023

Proposed change

Follow up to #4269, bind is not a type for mount. There is no type and you say bind as an option, this does bind mounts correctly.

In addition when we fail to mount on create, keep the new mount out of the list of mounts. Rather then adding it as a failure. Also try to remove the systemd unit first if it was created so the user doesn't get a confusing error when they retry.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to the supervisor)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to cli pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast supervisor tests)
  • Tests have been added to verify that the new code works.

If API endpoints of add-on configuration are added/changed:

@mdegat01 mdegat01 added the bugfix A bug fix label May 1, 2023
@mdegat01 mdegat01 requested a review from pvizeli May 1, 2023 16:38
supervisor/mounts/manager.py Outdated Show resolved Hide resolved
@pvizeli pvizeli merged commit 7688e1b into main May 2, 2023
23 checks passed
@pvizeli pvizeli deleted the fix-bind-mounts branch May 2, 2023 06:33
@github-actions github-actions bot locked and limited conversation to collaborators May 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants