Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for network mounts #4269

Merged
merged 3 commits into from
May 1, 2023
Merged

Add support for network mounts #4269

merged 3 commits into from
May 1, 2023

Conversation

mdegat01
Copy link
Contributor

@mdegat01 mdegat01 commented Apr 28, 2023

Proposed change

Add support for network mounts to supervisor. Initial support will include cifs and nfs. For cifs users can provide a username and password if auth is used.

When adding a network mount you must say if it is used for backups or media. If used for backups then users will be given an option to create or restore backups from there (to be implemented in subsequent PR). If used for media then the mount will be available as a folder in /media with the same name as the mount (this is implemented in this PR).

On startup supervisor will automatically try and mount all configured mounts. Or if it detects they are already mounted it adopts them. If supervisor cannot mount them for some reason it reports that as a supervisor issue (to be made into a core repair in a follow-up PR to core)

Steps still to do:

  1. Backups need to skip the mount folders in /media
  2. Changes to mounts need to persist across restarts correctly
  3. CLI changes to correspond to API changes
  4. Document new APIs
  5. Core repair from new MOUNT_FAILED issue

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to the supervisor)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast supervisor tests)
  • Tests have been added to verify that the new code works.

If API endpoints of add-on configuration are added/changed:

@mdegat01 mdegat01 added the new-feature A new feature label Apr 28, 2023
@mdegat01 mdegat01 requested a review from pvizeli April 28, 2023 03:59
@pvizeli pvizeli merged commit 34c394c into main May 1, 2023
23 checks passed
@pvizeli pvizeli deleted the add-network-mounts branch May 1, 2023 06:45
@github-actions github-actions bot locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants