Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Add support for network mounts to supervisor. Initial support will include cifs and nfs. For cifs users can provide a username and password if auth is used.
When adding a network mount you must say if it is used for backups or media. If used for backups then users will be given an option to create or restore backups from there (to be implemented in subsequent PR). If used for media then the mount will be available as a folder in
/media
with the same name as the mount (this is implemented in this PR).On startup supervisor will automatically try and mount all configured mounts. Or if it detects they are already mounted it adopts them. If supervisor cannot mount them for some reason it reports that as a supervisor issue (to be made into a core repair in a follow-up PR to core)
Steps still to do:
Backups need to skip the mount folders in/media
Changes to mounts need to persist across restarts correctlyCLI changes to correspond to API changesDocument new APIsMOUNT_FAILED
issueType of change
Additional information
Checklist
black --fast supervisor tests
)If API endpoints of add-on configuration are added/changed: