Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dock transparency disappears after exiting the Overview #1333

Closed
omentic opened this issue May 11, 2021 · 28 comments
Closed

Dock transparency disappears after exiting the Overview #1333

omentic opened this issue May 11, 2021 · 28 comments

Comments

@omentic
Copy link

omentic commented May 11, 2021

Describe the bug
On GNOME 40, the panel's background turns to black regardless of opacity setting after exiting the Overview menu. Locking and unlocking the screen or disabling and enabling the extension temporarily fixes the problem.

This was the most common bug reported in #1303.

Linux distribution and version
Arch 5.12

GNOME Shell version
40.1

Dash-to-Panel version
42

Where was Dash-to-Panel installed from?
gnome-shell-extension-dash-to-panel-git from the AUR.

Screenshots / Video captures
Before entering the overview:
2021-05-11-003412

After leaving the overview:
2021-05-11-003417

Additional Info
A tremendous thank you to everyone involved in porting this extension to GNOME 40, especially @philippun1!

@omentic omentic added the bug label May 11, 2021
@omentic omentic changed the title Dock transparency disappears after entering and exiting the Overview Dock transparency disappears after exiting the Overview May 11, 2021
@Testing-XYZ
Copy link

Not sure how to fix this issue in extension but here is a workaround. Run the following command in bash at startup:

gdbus call --session --dest org.gnome.Shell --object-path /org/gnome/Shell --method org.gnome.Shell.Eval 'Function.prototype.clone = function() { var that = this; var temp = function temporary() { return that.apply(this, arguments); }; for(var key in this) { if (this.hasOwnProperty(key)) { temp[key] = this[key]; } } return temp; }; Main.overview._hideDoneClone = Main.overview._hideDone.clone(); Main.overview._hideDone = function() { Main.overview._hideDoneClone(); Main.loadTheme(); };'

Basically reloads theme after hiding overview and as a result there is a slight delay. The clone function comes from here. It's quite inelegant but I'm not familiar with Gjs.

@philippun1
Copy link
Contributor

@Testing-XYZ @J-James I made a pull request #1337 (yes, this is some leet shit ^^). Please check if this fixes the issue for you.

@omentic
Copy link
Author

omentic commented May 13, 2021

It does indeed! The panel does noticeably flash black when exiting the overview quickly, but I think that's more to do with a different bug (the slight jumpiness of the exit overview animation)

@omentic
Copy link
Author

omentic commented May 13, 2021

Hmm, strangely enough, this fix stops working after some time. Disabling and reenabling the extension brings back the transparently temporarily, but only until the next overview exit.

@philippun1
Copy link
Contributor

@J-James I had this behaviour once, but I cannot reproduce it. Indeed strange. I will keep an eye on this.

@sc44
Copy link

sc44 commented May 14, 2021

Hello,
i used the Transparent Shell extension to fix this.
But since yesterday i test the fix from @philippun1 and i have no problems. The fix runs for me. Thanks.

Gnome Shell ver. 40.1 on Arch Linux.
Dash-to-Panel ver. 9999 git with fix. Not AUR.

@j-zero
Copy link

j-zero commented May 25, 2021

I can confirm this bug on Arch Linux, Gnome Shell 40.1 and dash-to-panel-git from AUR

@ConstantMan
Copy link

I can confirm this bug on Arch Linux, Gnome Shell 40.1 and dash-to-panel-git from AUR

@jderose9
Copy link
Contributor

jderose9 commented Jun 9, 2021

It seems like this one was resolved by ec4e078. Let me know if it persists and I will re-open.

@jderose9 jderose9 closed this as completed Jun 9, 2021
@omentic
Copy link
Author

omentic commented Jun 9, 2021

I am actually seeing a bunch of more bugs after updating on Wayland - the disappearing transparency remains, the overview has become unusable, and switching between the desktop and the overview is stuttery and flashes grey. I'll try and make sure this isn't an issue on my end, and get a recording this afternoon.

@jderose9
Copy link
Contributor

jderose9 commented Jun 9, 2021

Oh I see, yes this still seems to be broken in Wayland.

@jderose9 jderose9 reopened this Jun 9, 2021
@omentic
Copy link
Author

omentic commented Jun 11, 2021

Here's a recording of the overview issue:

greyscreen.mp4

@ConstantMan
Copy link

It seems like this one was resolved by ec4e078. Let me know if it persists and I will re-open.

I can confirm this bug remains on Arch Linux, Gnome Shell 40.1 X11 and dash-to-panel-git from AUR

@philippun1
Copy link
Contributor

This bug seems to be fixed with 258083f. Tested on Ubuntu and Manjaro.

@ConstantMan
Copy link

This bug seems to be fixed with 258083f. Tested on Ubuntu and Manjaro.

Manjaro and Ubuntu don't support gnome-shell 40 yet
so the bug remains
Tested on Arch Linux, Gnome Shell 40.1 X11 and dash-to-panel-git from AUR

@jderose9
Copy link
Contributor

I think this one is fixed, for real this time.

@philippun1
Copy link
Contributor

@KonstantMan Please pull the latest master branch, the AUR package is outdated, and verify again.
Ubuntu with shemgp PPA has Gnome 40.1 and Manjaro testing has Gnome 40.2.

@jderose9 Sadly I just noticed that it does not work if you use the three finger swipe up gesture on wayland. Clicking on "Show Applications" and using the Super Key works fine though. Anyone can confirm this?

@omentic
Copy link
Author

omentic commented Jun 16, 2021

Something I didn't notice before is that this isn't just transparency styles, overriding the panel background color at all (even with a solid color) will trigger this bug.

@Testing-XYZ
Copy link

Sadly I just noticed that it does not work if you use the three finger swipe up gesture on wayland. Clicking on "Show Applications" and using the Super Key works fine though. Anyone can confirm this?

I can confirm that gesture-triggered overview do not produce transparency. Tested on Arch and dash-to-panel-git from AUR.

@jderose9
Copy link
Contributor

Ok, I will do the shameful double re-open :)

@jderose9 jderose9 reopened this Jun 17, 2021
@jderose9
Copy link
Contributor

Looks like in overview.js, it will need to be overridden somehow where the panel style is cleared. There's one instance in _gestureEnd and two in runStartupAnimation.
https://gitlab.gnome.org/GNOME/gnome-shell/-/blob/master/js/ui/overview.js#L396
https://gitlab.gnome.org/GNOME/gnome-shell/-/blob/master/js/ui/overview.js#L650
https://gitlab.gnome.org/GNOME/gnome-shell/-/blob/master/js/ui/overview.js#L671

The _gestureEnd is going to be a pain to override though with the way the signal is bound to that method on init.

@jderose9
Copy link
Contributor

Ok, anyone want to give this new commit a whirl? Thanks!

@omentic
Copy link
Author

omentic commented Jun 19, 2021

Looks to be working!

@philippun1
Copy link
Contributor

@jderose9 Can confirm it works now.

@philippun1
Copy link
Contributor

philippun1 commented Jun 19, 2021

Now there is
JS ERROR: Extension dash-to-panel@jderose9.github.com: TypeError: can't redefine non-configurable property "style"
after suspend and resume.
A simple try/catch fixes it, but I'm not sure if there are any drawbacks...

@jderose9 I made a pull request #1369 which fixes the issue. Hopefully this time for real.

@omentic
Copy link
Author

omentic commented Jun 19, 2021

When I get that error, my bar looks like this:

2021-06-19-161057

The applications are squished and the bar appears over fullscreen windows.

@jderose9
Copy link
Contributor

@philippun1 Made commit 6e50948 before I saw your PR, sorry!

@omentic
Copy link
Author

omentic commented Jul 14, 2021

This issue hasn't shown up at all since 35081df, so I'm closing this unless anyone else still has problems. Thanks to everyone who worked on fixing it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants