Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix transparency issue after overview has been shown and hidden #1337

Conversation

philippun1
Copy link
Contributor

This is a workaround / potential fix for the transparency issue after exit overview.

@philippun1 philippun1 marked this pull request as draft May 13, 2021 09:51
@philippun1 philippun1 marked this pull request as ready for review May 13, 2021 19:34
@Alexmitter
Copy link

Alexmitter commented May 14, 2021

You probably already noticed that. When the Panel is black due to this bug and you enter the overview, it becomes transparent again while it is in the overview, it is just very hard to see. When you exit the overview it transforms into solid black again.
Something seems to set the panel to black when it is outside the overview and that code is most likely triggered when existing the overview as the bug only happens after entering and leaving the overview once.

It may be the same code that sets the standard top bar black outside the overview and makes it transparent when entering it. It shows the same fade animation.

Reloading the theme on overview exit is only really a workaround.

@Testing-XYZ
Copy link

Reloading the theme on overview exit is only really a workaround.

I agree with Alexmitter. Reloading the theme by changing Main.overview._hideDone result in glitchy animation for now and might cause other problems in the future.

Is there any good documentation on Main.overview?

@work-chausat
Copy link

If you use a override color for taskbar, after the button was clicked, the backgroud of taskbar changed to black, "override panel theme background color" doesn't work!!!!!

@Alexmitter
Copy link

To add some information, using the extension blur-my-shell (https://extensions.gnome.org/extension/3193/blur-my-shell/) fixes the black panel issue, something they do works.

@philippun1 philippun1 marked this pull request as draft May 25, 2021 22:08
@work-chausat
Copy link

@philippun1
97e91e3 doesn't works after i locked my screen.

@Alexmitter
Copy link

@philippun1 For me it too freaks out sometimes when I activate the log screen with this patch, the error reported is: this.panel._leftCorner is undefined

@philippun1
Copy link
Contributor Author

Yes, I'm aware a lot of things are broken right now, due to this change. That's why I made this PR draft again.
The old workaround was not really good. And I also tried blur-my-shell. But they seem to have similar issues (i.e. #10, #31) at least there is no "real" transparency only a blurry panel.

Using the dtpSeconaryPanel (and not showing the top panel) fixes the transparency issue, but breaks a lot of other stuff. I don't know if this is the correct way to go, many things would have to be refactored to fix all the problem that are caused by this change.
@jderose9 Do you think this would be a proper solution? Sadly I do not know the code of dtp good enough (yet) to make an estimation.

@jderose9
Copy link
Contributor

jderose9 commented Jun 9, 2021

I think this was fixed by ec4e078.

@jderose9 jderose9 closed this Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants