Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix touchscreen behaviour for taskbarAppIcon (#223) #350

Merged
merged 2 commits into from
Mar 14, 2018

Conversation

moqmar
Copy link
Contributor

@moqmar moqmar commented Mar 5, 2018

Behaviour that might be unexpected:

  • long-pressing a background application opens the popup menu, but still activates/starts the application. Only activating the application on TOUCH_END/TOUCH_CANCEL turned out to work only sometimes on my system, I'll do some further tests on that.
  • dragging via touchscreen is completely disabled for now, as it gets confused with the mouse, bugs around and in the end breaks everything (as said in the issue, up to a frozen system).

@moqmar
Copy link
Contributor Author

moqmar commented Mar 5, 2018

Alright, turns out that the TOUCH_END/TOUCH_CANCEL events only fire sometimes, for completely unknown reasons, although I don't know why the popup doesn't open in those cases... :/

@moqmar
Copy link
Contributor Author

moqmar commented Mar 5, 2018

Ah, it doesn't open because a leave event is fired instead. So, the fix now behaves as expected.

@jderose9
Copy link
Contributor

Great, thank you!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants