feat: add disabled flag and tooltip to radio group field options (sc-25841) #791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #25831: [UI] Archive templates modal. |
Andrielson
requested review from
stephenh,
bdow,
KoltonG,
ksk5280,
chr1sjf0x and
DeanGilewicz
as code owners
stephenh
reviewed
Jan 19, 2023
stephenh
approved these changes
Jan 19, 2023
| ]} | ||
| />, | ||
| ); | ||
| const radioInput = r.container.querySelector(`[data-testid="favoriteCheese_a"]`)!; |
There was a problem hiding this comment.
Suggestion: Given how our render DSL works, this can probably be just:
expect(r.favoriteCheese_a).toBeDisabled();
I think?
There was a problem hiding this comment.
I've tried this approach, but it returns an error:
TypeError: Cannot read property 'message' of undefined
at new JestAssertionError (~/homebound/beam/node_modules/jest-chain/dist/chain.js:10:18)
at Object.newMatcher [as toBeDisabled] (~/homebound/beam/node_modules/jest-chain/dist/chain.js:31:17)
at Object.<anonymous> (~/homebound/beam/src/inputs/RadioGroupField.test.tsx:32:31)
There was a problem hiding this comment.
Ah yeah, np that this is merged, but I forgot the (), so:
expect(r.favoriteCheese_a()).toBeDisabled()
homebound-team-bot
pushed a commit
that referenced
this pull request
Jan 19, 2023
## [2.239.0](v2.238.2...v2.239.0) (2023-01-19) ### Features * add disabled flag and tooltip to radio group field options (sc-25841) ([#791](#791)) ([a69611a](a69611a))
|
🎉 This PR is included in version 2.239.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in RadioGroupField include:
disabledattribute toRadioFieldOptiondisabledTooltipattribute toRadioFieldOption