feat: GridTable header now supports a maximum of two lines of text. #800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdow
requested review from
stephenh,
KoltonG,
ksk5280,
chr1sjf0x and
DeanGilewicz
as code owners
|
This pull request has been linked to Shortcut Story #28525: GridTable Headers to support showing two lines of text. |
kbesingeryeh
approved these changes
Feb 2, 2023
bdow
force-pushed
the
sc-28525/header-max-two-lines
branch
from
df86404
to
2a1e931
Compare
stephenh
reviewed
Feb 2, 2023
src/components/Table/TableStyles.tsx
Outdated
| @@ -103,7 +103,9 @@ function memoizedTableStyles() { | |||
| emptyCell: "-", | |||
| firstRowMessageCss: Css.tc.py3.$, | |||
| headerCellCss: { | |||
| ...Css.gray700.xsMd.bgGray200.aic.nowrap.pxPx(12).hPx(40).$, | |||
| // `unset`-ing the white-space: nowrap defined in `cellCss` below. Header's will add `lineClamp2` more locally in their renders. | |||
| // Not setting `lineClamp2` here as it sets `display: webkit-box`, which disables `align-items: center` (requires `display: flex/grid`) | |||
There was a problem hiding this comment.
Suggestion: Maybe prefix both of these lines with just a contextual: "We want to support headers having two lines of wrapped text, and could add a lineClamp2 here, but ...what you have..."
homebound-team-bot
pushed a commit
that referenced
this pull request
Feb 2, 2023
## [2.242.0](v2.241.2...v2.242.0) (2023-02-02) ### Features * GridTable header now supports a maximum of two lines of text. ([#800](#800)) ([850ed22](850ed22))
|
🎉 This PR is included in version 2.242.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.