feat: Add right pane column content #835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crshannon
requested review from
bdow,
KoltonG,
ksk5280,
chr1sjf0x and
DeanGilewicz
as code owners
|
This pull request has been linked to Shortcut Story #31107: RightPaneLayout - swap out right column (2m). |
stephenh
approved these changes
Mar 24, 2023
| }: { | ||
| children: ReactElement; | ||
| paneBgColor?: Palette; | ||
| paneWidth?: number; | ||
| rightColumnContent?: ReactElement; |
There was a problem hiding this comment.
Suggestion: I'm wondering if we should call this like defaultContent or primaryContent ... just something to highlight that it's the default/primary content until something else within the pane is opened.
...defaultPaneContent ... wdyt?
There was a problem hiding this comment.
sounds good to me - always open to suggestions, made the change
homebound-team-bot
pushed a commit
that referenced
this pull request
Mar 24, 2023
## [2.260.0](v2.259.0...v2.260.0) (2023-03-24) ### Features * Add right pane column content ([#835](#835)) ([cc7e0f1](cc7e0f1))
|
🎉 This PR is included in version 2.260.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SC-31107
rightColumnContentand have that swap out with therightPaneContent