Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UX fix - Properly allow quarantine in 'upgrade' #10398

Merged
merged 2 commits into from Jan 25, 2021
Merged

UX fix - Properly allow quarantine in 'upgrade' #10398

merged 2 commits into from Jan 25, 2021

Conversation

AntonioMeireles
Copy link
Contributor

Hi all,

issue was raised in #9139 for {upgrade,reinstall} --cask and was then
closed by #10284. Point is that #10284 only actually fixed the reinstall
command, leaving behindd the upgrade one which this now fixes.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

All the best, a great weekend && stay safe

António

AntonioMeireles and others added 2 commits January 22, 2021 17:39
@AntonioMeireles
Properly allow quarantine in 'upgrade'
19f41bd 
issue was raised in Homebrew#9139 for upgrade/reinstall --cask and was then
closed by Homebrew#10284. Issue is that Homebrew#10284 only actually fixed the reinstall
command, leaving behindd the 'upgrade' one which this now fixes.

Signed-off-by: António Meireles <antonio.meireles@reformi.st>
@SeekingMeaning
Fix remaining broken cask options in upgrade
9a99c40
@MikeMcQuaid MikeMcQuaid added the critical Critical change which should be shipped as soon as possible. label Jan 25, 2021
MikeMcQuaid
MikeMcQuaid approved these changes Jan 25, 2021
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for your first contribution! Without people like you submitting PRs we couldn't run this project. You rock, @AntonioMeireles!

@MikeMcQuaid MikeMcQuaid merged commit 1a20365 into Homebrew:master Jan 25, 2021
@AntonioMeireles AntonioMeireles deleted the allowQuarentineOnUpgrade branch January 25, 2021 09:44
@SeekingMeaning SeekingMeaning mentioned this pull request Jan 25, 2021
Merged
8 tasks
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Feb 25, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Feb 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

Assignees
No one assigned
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@AntonioMeireles @MikeMcQuaid @BrewTestBot @SeekingMeaning