Skip to content

Properly pass cask options in reinstall.#10284

Merged
reitermarkus merged 1 commit intoHomebrew:masterfrom
reitermarkus:reinstall-cask-options
Jan 10, 2021
Merged

Properly pass cask options in reinstall.#10284
reitermarkus merged 1 commit intoHomebrew:masterfrom
reitermarkus:reinstall-cask-options

Conversation

@reitermarkus
Copy link
Copy Markdown
Member

@reitermarkus reitermarkus commented Jan 10, 2021 •
edited
Loading

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

Fixes #9139.

@reitermarkus reitermarkus added the critical Critical change which should be shipped as soon as possible. label Jan 10, 2021
@BrewTestBot
Copy link
Copy Markdown
Contributor

BrewTestBot commented Jan 10, 2021

Review period skipped due to critical label.

1 similar comment
@BrewTestBot
Copy link
Copy Markdown
Contributor

BrewTestBot commented Jan 10, 2021

Review period skipped due to critical label.

@reitermarkus reitermarkus merged commit 6968c19 into Homebrew:master Jan 10, 2021
@reitermarkus reitermarkus deleted the reinstall-cask-options branch January 10, 2021 20:04
AntonioMeireles added a commit to AntonioMeireles/brew that referenced this pull request Jan 22, 2021
@AntonioMeireles
Properly allow quarantine in 'upgrade'
19f41bd 
issue was raised in Homebrew#9139 for upgrade/reinstall --cask and was then
closed by Homebrew#10284. Issue is that Homebrew#10284 only actually fixed the reinstall
command, leaving behindd the 'upgrade' one which this now fixes.

Signed-off-by: António Meireles <antonio.meireles@reformi.st>
@AntonioMeireles AntonioMeireles mentioned this pull request Jan 22, 2021
Merged
8 tasks
@SeekingMeaning SeekingMeaning mentioned this pull request Jan 25, 2021
Merged
8 tasks
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Feb 10, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Feb 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@BrewTestBot BrewTestBot BrewTestBot approved these changes

Assignees

No one assigned

Labels

critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

New brew upgrade/reinstall --cask does not honour --no-quarantine

2 participants

@reitermarkus @BrewTestBot