Skip to content

uninstall: delete references to unused --binaries flag#10421

Merged
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
SeekingMeaning:uninstall-cask-binaries
Feb 23, 2021
Merged

uninstall: delete references to unused --binaries flag#10421
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
SeekingMeaning:uninstall-cask-binaries

Conversation

@SeekingMeaning
Copy link
Copy Markdown
Contributor

@SeekingMeaning SeekingMeaning commented Jan 25, 2021

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

Similar to #10284 and #10398, this PR replaces EnvConfig.cask_opts_ with args.

Delete references to unused --binaries flag

@BrewTestBot
Copy link
Copy Markdown
Contributor

Review period will end on 2021-01-26 at 19:46:53 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Jan 25, 2021
@MikeMcQuaid MikeMcQuaid added the critical Critical change which should be shipped as soon as possible. label Jan 26, 2021
@BrewTestBot
Copy link
Copy Markdown
Contributor

BrewTestBot commented Jan 26, 2021

Review period ended.

@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Jan 26, 2021
@SeekingMeaning
Copy link
Copy Markdown
Contributor Author

brew uninstall doesn't have a --binaries option

$ brew uninstall --cask --binaries adoptopenjdk
Usage: brew uninstall, remove, rm [options] installed_formula|installed_cask
...
Error: invalid option: --binaries

@reitermarkus
Copy link
Copy Markdown
Member

Isn't this stored when installing the cask? I don't think uninstall should (need to) have this option.

@SeekingMeaning SeekingMeaning force-pushed the uninstall-cask-binaries branch from 940cf84 to b220076 Compare February 23, 2021 03:44
@SeekingMeaning SeekingMeaning changed the title uninstall: fix broken cask option uninstall: delete references to unused --binaries flag Feb 23, 2021
@SeekingMeaning SeekingMeaning force-pushed the uninstall-cask-binaries branch from b220076 to 880a82d Compare February 23, 2021 03:49
@SeekingMeaning SeekingMeaning removed the critical Critical change which should be shipped as soon as possible. label Feb 23, 2021
@MikeMcQuaid MikeMcQuaid merged commit 3efab3e into Homebrew:master Feb 23, 2021
@MikeMcQuaid
Copy link
Copy Markdown
Member

Thanks @SeekingMeaning!

@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Mar 26, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Mar 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants