Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uninstall: delete references to unused --binaries flag #10421

Merged
merged 1 commit into from Feb 23, 2021

Conversation

SeekingMeaning
Copy link
Contributor

@SeekingMeaning SeekingMeaning commented Jan 25, 2021

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

Similar to #10284 and #10398, this PR replaces EnvConfig.cask_opts_ with args.

Delete references to unused --binaries flag

@BrewTestBot
Copy link
Member

Review period will end on 2021-01-26 at 19:46:53 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Jan 25, 2021
@MikeMcQuaid MikeMcQuaid added the critical Critical change which should be shipped as soon as possible. label Jan 26, 2021
@BrewTestBot
Copy link
Member

BrewTestBot commented Jan 26, 2021

Review period ended.

@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Jan 26, 2021
@SeekingMeaning
Copy link
Contributor Author

brew uninstall doesn't have a --binaries option

$ brew uninstall --cask --binaries adoptopenjdk
Usage: brew uninstall, remove, rm [options] installed_formula|installed_cask
...
Error: invalid option: --binaries

@reitermarkus
Copy link
Member

Isn't this stored when installing the cask? I don't think uninstall should (need to) have this option.

@SeekingMeaning SeekingMeaning changed the title uninstall: fix broken cask option uninstall: delete references to unused --binaries flag Feb 23, 2021
@SeekingMeaning SeekingMeaning removed the critical Critical change which should be shipped as soon as possible. label Feb 23, 2021
@MikeMcQuaid MikeMcQuaid merged commit 3efab3e into Homebrew:master Feb 23, 2021
@MikeMcQuaid
Copy link
Member

Thanks @SeekingMeaning!

@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Mar 26, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Mar 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants