New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
uninstall: delete references to unused --binaries
flag
#10421
Merged
MikeMcQuaid
merged 1 commit into
Homebrew:master
from
SeekingMeaning:uninstall-cask-binaries
Feb 23, 2021
Merged
uninstall: delete references to unused --binaries
flag
#10421
MikeMcQuaid
merged 1 commit into
Homebrew:master
from
SeekingMeaning:uninstall-cask-binaries
Feb 23, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review period will end on 2021-01-26 at 19:46:53 UTC. |
BrewTestBot
added
the
waiting for feedback
Merging is blocked until sufficient time has passed for review
label
Jan 25, 2021
MikeMcQuaid
approved these changes
Jan 26, 2021
MikeMcQuaid
added
the
critical
Critical change which should be shipped as soon as possible.
label
Jan 26, 2021
Review period ended. |
BrewTestBot
removed
the
waiting for feedback
Merging is blocked until sufficient time has passed for review
label
Jan 26, 2021
BrewTestBot
approved these changes
Jan 26, 2021
$ brew uninstall --cask --binaries adoptopenjdk
Usage: brew uninstall, remove, rm [options] installed_formula|installed_cask
...
Error: invalid option: --binaries |
Isn't this stored when installing the cask? I don't think |
SeekingMeaning
force-pushed
the
uninstall-cask-binaries
branch
from
February 23, 2021 03:44
940cf84
to
b220076
Compare
SeekingMeaning
changed the title
uninstall: fix broken cask option
uninstall: delete references to unused Feb 23, 2021
--binaries
flag
SeekingMeaning
force-pushed
the
uninstall-cask-binaries
branch
from
February 23, 2021 03:49
b220076
to
880a82d
Compare
SeekingMeaning
removed
the
critical
Critical change which should be shipped as soon as possible.
label
Feb 23, 2021
MikeMcQuaid
approved these changes
Feb 23, 2021
Thanks @SeekingMeaning! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?brew man
locally and committed any changes?Similar to #10284 and #10398, this PR replacesEnvConfig.cask_opts_
withargs.
Delete references to unused
--binaries
flag