Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

formula auditor: skip uses_from_macos audit for linux-only formula #11079

Merged
merged 1 commit into from Apr 8, 2021
Merged

formula auditor: skip uses_from_macos audit for linux-only formula #11079

merged 1 commit into from Apr 8, 2021

Conversation

iMichka
Copy link
Member

@iMichka iMichka commented Apr 8, 2021

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@iMichka iMichka requested a review from dawidd6 April 8, 2021 20:58
@BrewTestBot
Copy link
Member

Review period will end on 2021-04-09 at 20:58:59 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Apr 8, 2021
@iMichka
Copy link
Member Author

iMichka commented Apr 8, 2021

Needed for Homebrew/homebrew-core#74219

@iMichka iMichka requested a review from bayandin April 8, 2021 20:59
@dawidd6 dawidd6 added the critical Critical change which should be shipped as soon as possible. label Apr 8, 2021
@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Apr 8, 2021
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@dawidd6 dawidd6 merged commit 77a360b into Homebrew:master Apr 8, 2021
@iMichka iMichka deleted the newdeps branch April 9, 2021 05:41
@MikeMcQuaid
Copy link
Member

👍🏻 on this change as-is. Suggestion: uses_from_macos is actively forbidden in the case that there's a depends_on :linux (which would necessitate a new audit).

@github-actions github-actions bot added the outdated PR was locked due to age label May 10, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BrewTestBot BrewTestBot BrewTestBot approved these changes

@dawidd6 dawidd6 dawidd6 approved these changes

@bayandin bayandin Awaiting requested review from bayandin

Assignees
No one assigned
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@iMichka @BrewTestBot @MikeMcQuaid @dawidd6