Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile: remove extraneous permission modification commands #11818

Merged
merged 1 commit into from Aug 12, 2021
Merged

Dockerfile: remove extraneous permission modification commands #11818

merged 1 commit into from Aug 12, 2021

Conversation

sudoforge
Copy link

@sudoforge sudoforge commented Aug 4, 2021

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Dockerfile: remove extraneous permission modification commands

These are no longer necessary due to the fact that the second `RUN`
instruction runs as the `linuxbrew` user (as of commit
77afe94446e78e688ebde7a5e2b1249fc0a4afcd).

THIS PR DEPENDS ON #11815. DO NOT MERGE UNTIL IT IS MARKED READY

@sudoforge sudoforge changed the title Docker remove extraneous commands Dockerfile: remove extraneous permission modification commands Aug 4, 2021
@sudoforge sudoforge marked this pull request as ready for review August 10, 2021 19:39
@sudoforge
Copy link
Author

@dawidd6 please review/merge this before #11819.

@dawidd6
Copy link
Member

dawidd6 commented Aug 11, 2021

I don't think you've rebased correctly.

These are no longer necessary due to the fact that the second `RUN`
instruction runs as the `linuxbrew` user (as of commit
77afe94).
@sudoforge
Copy link
Author

Whoops, you're correct -- I rebased on top of my fork's head branch, which caused those commits to be picked up (because the hashes differ). This has now been fixed.

@MikeMcQuaid MikeMcQuaid merged commit 9fe6427 into Homebrew:master Aug 12, 2021
@MikeMcQuaid
Copy link
Member

Thanks again @sudoforge!

@sudoforge sudoforge deleted the docker-remove-extraneous-commands branch August 12, 2021 19:53
iMichka added a commit that referenced this pull request Aug 18, 2021
iMichka added a commit that referenced this pull request Aug 18, 2021
Dockerfile: revert the revert of #11818 and #11819
@github-actions github-actions bot added the outdated PR was locked due to age label Sep 12, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants