Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dockerfile: revert #11818 and #11819 #11873

Merged
merged 2 commits into from Aug 18, 2021
Merged

Dockerfile: revert #11818 and #11819 #11873

merged 2 commits into from Aug 18, 2021

Conversation

iMichka
Copy link
Member

@iMichka iMichka commented Aug 18, 2021 •
edited

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This broke the CI in the test-bot repo: Homebrew/homebrew-test-bot#653 (comment)

cc @dawidd6 @sudoforge

@BrewTestBot
Copy link
Member

Review period will end on 2021-08-19 at 10:42:23 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Aug 18, 2021
@iMichka iMichka added the critical Critical change which should be shipped as soon as possible. label Aug 18, 2021
@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Aug 18, 2021
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@iMichka iMichka merged commit 25cc6f7 into Homebrew:master Aug 18, 2021
@iMichka iMichka deleted the revert branch August 18, 2021 11:26
rlane2126
rlane2126 reviewed Aug 22, 2021
View reviewed changes
Copy link

@rlane2126 rlane2126 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@sudoforge
Copy link

approved

... ? This was merged in 4 days ago, and subsequently reverted in #11877.

@iMichka
Copy link
Member Author

iMichka commented Aug 22, 2021

Probably a bot spamming the topic. We have seen many lately trying to post nonsense. I'm going to lock this topic.

@Homebrew Homebrew locked as spam and limited conversation to collaborators Aug 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rlane2126 rlane2126 rlane2126 left review comments

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

@BrewTestBot BrewTestBot BrewTestBot approved these changes

Assignees
No one assigned
Labels
critical Critical change which should be shipped as soon as possible.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@iMichka @BrewTestBot @sudoforge @MikeMcQuaid @rlane2126