Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade: fetch all formulae before installing #11940

Merged
merged 3 commits into from Aug 31, 2021

Conversation

FnControlOption
Copy link
Contributor

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good so far! Nothing to do here but in future reference you can just force push to an existing PR instead of opening a new one.

Library/Homebrew/upgrade.rb Outdated Show resolved Hide resolved
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! One naming thought.

@@ -82,7 +87,7 @@ def print_upgrade_message(formula, fi_options)
EOS
end

def upgrade_formula(
def fetch_formula_installer(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
def fetch_formula_installer(
def fetched_formula_installer(

or

Suggested change
def fetch_formula_installer(
def fetch_and_return_formula_installer(

Library/Homebrew/upgrade.rb Outdated Show resolved Hide resolved
Library/Homebrew/upgrade.rb Outdated Show resolved Hide resolved
Library/Homebrew/upgrade.rb Outdated Show resolved Hide resolved
@MikeMcQuaid
Copy link
Member

Thanks again @FnControlOption!

@MikeMcQuaid MikeMcQuaid merged commit d429780 into Homebrew:master Aug 31, 2021
@FnControlOption
Copy link
Contributor Author

Why rename to create_and_fetch_formula_installer when fi.fetch happens outside the method?

@MikeMcQuaid
Copy link
Member

@FnControlOption I misread your most recent changes, sorry 🤦🏻. I can open a PR to revert or you can, what would you rather?

@github-actions github-actions bot added the outdated PR was locked due to age label Oct 2, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants