New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade: fetch all formulae before installing #11940
upgrade: fetch all formulae before installing #11940
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good so far! Nothing to do here but in future reference you can just force push to an existing PR instead of opening a new one.
3ba444d
to
367e957
Compare
367e957
to
f45c114
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! One naming thought.
Library/Homebrew/upgrade.rb
Outdated
@@ -82,7 +87,7 @@ def print_upgrade_message(formula, fi_options) | |||
EOS | |||
end | |||
|
|||
def upgrade_formula( | |||
def fetch_formula_installer( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
def fetch_formula_installer( | |
def fetched_formula_installer( |
or
def fetch_formula_installer( | |
def fetch_and_return_formula_installer( |
Thanks again @FnControlOption! |
Why rename to |
@FnControlOption I misread your most recent changes, sorry 🤦🏻. I can open a PR to revert or you can, what would you rather? |
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?