Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: use actions/cache@v3 #14695

Merged
merged 1 commit into from Mar 19, 2023
Merged

CI: use actions/cache@v3 #14695

merged 1 commit into from Mar 19, 2023

Conversation

CodeWithShreyans
Copy link
Contributor

@CodeWithShreyans CodeWithShreyans commented Feb 17, 2023 •
edited

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

fixes #14692
I can't confirm if these changes work as they are related to cache which I can't test in my fork.

@CodeWithShreyans
Copy link
Contributor Author

It can't find the cache for some reason it seems
Checking this out

@CodeWithShreyans
Copy link
Contributor Author

Seems to work fine now
Learned that GitHub cache was scoped to a branch so just force-pushed the same commit again to use the newly created cache.

@MikeMcQuaid
Copy link
Member

CI is failing: https://github.com/Homebrew/brew/actions/runs/4206541156/jobs/7300184415#step:2:12

@CodeWithShreyans
Copy link
Contributor Author

These failures are very weird.
I didn't make any changes related to them.

@Bo98
Copy link
Member

Bo98 commented Feb 17, 2023

GitHub appears to be having some issues right now. I'll retry the failing ones where needed.

@scpeters
Copy link
Member

GitHub appears to be having some issues right now. I'll retry the failing ones where needed.

the following issue report seems related: Homebrew/actions#333

@Bo98
Copy link
Member

Bo98 commented Feb 17, 2023

Yeah I'm working on it

@CodeWithShreyans
Copy link
Contributor Author

any updates on this?

@Bo98
Copy link
Member

Bo98 commented Feb 27, 2023

Can you rebase on the latest master? Should be good then.

@CodeWithShreyans
Copy link
Contributor Author

@Bo98 done

carlocab
carlocab approved these changes Mar 18, 2023
View reviewed changes
Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

issyl0
issyl0 approved these changes Mar 19, 2023
View reviewed changes
Copy link
Member

@issyl0 issyl0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for this contribution to Homebrew, @DestroyerXyz!

@issyl0
Copy link
Member

issyl0 commented Mar 19, 2023

We changed some CI jobs in the time between this PR and now. Would you be able to rebase on our latest master again please @DestroyerXyz so that all the pending yellow checks run?

@CodeWithShreyans
fix: save-state and set-output deprecated
cef132f 
Signed-off-by: Shreyans Jain <shreyansthebest2007@gmail.com>
@CodeWithShreyans
Copy link
Contributor Author

@issyl0 Done and all CI passing

nandahkrishna
nandahkrishna approved these changes Mar 19, 2023
View reviewed changes
Copy link
Member

@nandahkrishna nandahkrishna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @DestroyerXyz!

@nandahkrishna nandahkrishna changed the title [CI] save-state and set-output deprecated CI: use actions/cache@v3 Mar 19, 2023
@nandahkrishna nandahkrishna merged commit 8f6276e into Homebrew:master Mar 19, 2023
27 checks passed
@github-actions github-actions bot added the outdated PR was locked due to age label Apr 19, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@issyl0 issyl0 issyl0 approved these changes

@carlocab carlocab carlocab approved these changes

@nandahkrishna nandahkrishna nandahkrishna approved these changes

@Bo98 Bo98 Awaiting requested review from Bo98

Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CI] Stop using deprecated Actions params
7 participants
@CodeWithShreyans @MikeMcQuaid @Bo98 @scpeters @issyl0 @carlocab @nandahkrishna