Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump msgpack from 1.7.0 to 1.7.1 in /Library/Homebrew #15467

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github May 19, 2023

Bumps msgpack from 1.7.0 to 1.7.1.

Changelog

Sourced from msgpack's changelog.

2023-05-19 1.7.1:

  • Fix JRuby 9.4 compatibility.
  • Fix compilation on older compilers (gcc 4.x).
  • Fix an infinite recursion issue when registering a Symbol type with a nil packer.
Commits
  • 78b48c6 Release 1.7.1 (for real)
  • 2062c52 Release 1.7.1
  • c5d862f Merge pull request #336 from Shopify/check-ext-code-fixnum
  • 34a7400 Packer_write_extension: handle T_BIGNUM
  • 1bad12b Merge pull request #335 from msgpack/test-static-insert
  • 92c5ecd Use a runtime assert during init instead of _Static_assert
  • 9e74c0b Merge pull request #332 from Shopify/infinite-symbol-recusrsion
  • 1ac6811 Merge pull request #333 from Shopify/jruby-9.4
  • f8833d4 Test JRuby 9.4 and fix compatibility
  • d7e4783 Fix an infinite recursion issue when registering a Symbol type with a nil p...
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Bumping Gemfile dependencies ruby Pull requests that update Ruby code labels May 19, 2023
@reitermarkus
Copy link
Member

@dependabot recreate

Bumps [msgpack](https://github.com/msgpack/msgpack-ruby) from 1.7.0 to 1.7.1.
- [Changelog](https://github.com/msgpack/msgpack-ruby/blob/master/ChangeLog)
- [Commits](msgpack/msgpack-ruby@v1.7.0...v1.7.1)

---
updated-dependencies:
- dependency-name: msgpack
  dependency-type: indirect
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/bundler/Library/Homebrew/msgpack-1.7.1 branch from 4ec371a to c6cae5b Compare May 20, 2023 18:47
@@ -0,0 +1 @@
mechanize-2.9.1/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dduugg, this symlink was removed in #15468, but brew vendor-gems recreated it. Didn't we remove mechanize from being vendored automatically?

Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFK traveling for the next couple weeks, but the symlink approach was authored by @MikeMcQuaid IIRC

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@reitermarkus

if args.non_bundler_gems?
%w[
mechanize
].each do |gem|
ohai "gem install #{gem}"
safe_system "gem", "install", "mechanize", "--install-dir", "vendor",
"--no-document", "--no-wrappers", "--ignore-dependencies", "--force"
(HOMEBREW_LIBRARY_PATH/"vendor/gems").cd do
if (source = Pathname.glob("#{gem}-*/").first)
FileUtils.ln_sf source, gem
end
end
end
end
is the relevant code that would need changed/fixed here. The symlink approach is so we can maintain some idea of what version these files came from and use gem to install/update them.

@reitermarkus reitermarkus merged commit 4446fe6 into master May 22, 2023
25 checks passed
@reitermarkus reitermarkus deleted the dependabot/bundler/Library/Homebrew/msgpack-1.7.1 branch May 22, 2023 07:21
@github-actions github-actions bot added the outdated PR was locked due to age label Jun 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Bumping Gemfile dependencies outdated PR was locked due to age ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants