Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

audit_file: check formula path #15948

Merged
merged 2 commits into from Sep 4, 2023
Merged

audit_file: check formula path #15948

merged 2 commits into from Sep 4, 2023

Conversation

bayandin
Copy link
Member

@bayandin bayandin commented Sep 4, 2023

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Ref Homebrew/homebrew-core#141362

MikeMcQuaid
MikeMcQuaid requested changes Sep 4, 2023
View reviewed changes
Library/Homebrew/formula_auditor.rb Outdated Show resolved Hide resolved
@bayandin @Bo98
audit_file: fix condition
b7cb835 
Co-authored-by: Bo Anderson <mail@boanderson.me>
@bayandin bayandin changed the title formula_auditor: check shard for core formulae audit_file: check formula path Sep 4, 2023
@MikeMcQuaid
Copy link
Member

Looks great, thanks @bayandin! Happy to be merged when it's no longer draft.

@bayandin
Copy link
Member Author

bayandin commented Sep 4, 2023

Looks great, thanks @bayandin! Happy to be merged when it's no longer draft.

Thanks!
As soon as Homebrew/homebrew-core#141362 is merged this one is good to go

@bayandin bayandin marked this pull request as ready for review September 4, 2023 17:47
@bayandin bayandin merged commit 27902f0 into Homebrew:master Sep 4, 2023
24 checks passed
@bayandin bayandin deleted the shard-audit branch September 4, 2023 18:39
@bayandin
Copy link
Member Author

bayandin commented Sep 4, 2023

Merged!
Thanks for the help Mike & Bo ❤️

@MikeMcQuaid
Copy link
Member

Thanks for the great work @bayandin!!

@github-actions github-actions bot added the outdated PR was locked due to age label Oct 5, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Bo98 Bo98 Bo98 left review comments

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bayandin @MikeMcQuaid @Bo98