Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split https_availability audit. #16438

Merged
merged 1 commit into from Jan 7, 2024

Conversation

reitermarkus
Copy link
Member

@reitermarkus reitermarkus commented Jan 6, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Allow more fine-grained control for excluding audits. For example, Homebrew/homebrew-cask#163887 shouldn't use ci-skip-livecheck to skip the homepage audit when there isn't even a livecheck anymore.

Copy link
Contributor

@apainintheneck apainintheneck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@bevanjkay
Copy link
Member

Having the extra label makes sense 👍🏻

Do we need to consider some adjustments with the way deprecated/disabled casks are handled in general for auditing? Probably an AGM discussion though.

@reitermarkus
Copy link
Member Author

the way deprecated/disabled casks are handled

I think we already have some handling that makes sense, e.g. ignoring livecheck for them. In this specific case with the knotes cask it's not even HTTPS availability that's the problem, but availability in general, since both HTTP and HTTPS return 503 Service Unavailable. Still worth discussing though.

@reitermarkus
Copy link
Member Author

Merge together with Homebrew/homebrew-cask#163916.

@reitermarkus reitermarkus merged commit 42a42c9 into Homebrew:master Jan 7, 2024
24 checks passed
@reitermarkus reitermarkus deleted the split-https-audit branch January 7, 2024 15:34
@bevanjkay
Copy link
Member

@github-actions github-actions bot added the outdated PR was locked due to age label Feb 7, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants