Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated commands used in completions, #8709

Closed
5 of 6 tasks
Amorymeltzer opened this issue Sep 12, 2020 · 4 comments
Closed
5 of 6 tasks

Deprecated commands used in completions, #8709

Amorymeltzer opened this issue Sep 12, 2020 · 4 comments
Labels
outdated PR was locked due to age stale No recent activity

Comments

@Amorymeltzer
Copy link
Contributor

Amorymeltzer commented Sep 12, 2020

Bug report

Please note we will close your issue without comment if you delete, do not read or do not fill out the issue checklist below and provide ALL the requested information. If you repeatedly fail to use the issue template, we will block you from ever submitting issues to Homebrew again.

  • ran brew update and can still reproduce the problem?
  • ran brew doctor, fixed all issues and can still reproduce the problem?
  • ran brew config and brew doctor and included their output with your issue?

What you were trying to do (and why)

Use bash tab completion to show outdated casks.

What happened (include command output)

Command output

> brew cask outdated <TAB>

> brew cask outdated Warning: Calling brew cask list is deprecated! Use brew list --cask instead.

Some cask sub commands have been incorporated into brew and are deprecated (see e.g. #8390 for a helpful list), but they persist in a few places, in particular in the docs (#8629, see also Homebrew/homebrew-cask#88682). The completion scripts also use some of these deprecated commands. Beyond fixing notable offenders from cask (like list and outdated), brew sub commands (like list and outdated) also need to learn about the --cask flag.

I suppose there could be a discussion about whether to remove deprecated commands while deprecated but present/functioning.

@MikeMcQuaid
Copy link
Member

@Amorymeltzer Was this fixed by #8710?

@Amorymeltzer
Copy link
Contributor Author

Amorymeltzer commented Sep 14, 2020

@MikeMcQuaid #8710 took care of it for bash — at least, I haven't run into anything — but AFAICT zsh and fish will still have some issues.

@stale
Copy link

stale bot commented Oct 12, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added stale No recent activity and removed stale No recent activity labels Oct 12, 2020
@BrewTestBot
Copy link
Member

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@BrewTestBot BrewTestBot added the stale No recent activity label Dec 1, 2020
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Jan 11, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Jan 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age stale No recent activity
Projects
None yet
Development

No branches or pull requests

3 participants