Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove NoDslVersion cop. #15392

Merged
merged 1 commit into from
May 10, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 0 additions & 3 deletions Library/.rubocop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,6 @@ Cask/Desc:
Cask/HomepageUrlTrailingSlash:
Description: "Ensure that the homepage url has a slash after the domain name."

Cask/NoDslVersion:
Description: "Do not use the deprecated DSL version syntax in your cask header."

Cask/StanzaGrouping:
Description: "Ensure that cask stanzas are grouped correctly. More info at https://docs.brew.sh/Cask-Cookbook#stanza-order"

Expand Down
10 changes: 1 addition & 9 deletions Library/Homebrew/rubocops/cask/ast/cask_header.rb
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,6 @@ def initialize(method_node)

attr_reader :method_node

def dsl_version?
hash_node
end

def header_str
@header_str ||= source_range.source
end
Expand All @@ -31,11 +27,7 @@ def preferred_header_str
end

def cask_token
@cask_token ||= if dsl_version?
pair_node.val_node.children.first
else
method_node.first_argument.str_content
end
@cask_token ||= method_node.first_argument.str_content
end

def hash_node
Expand Down
61 changes: 0 additions & 61 deletions Library/Homebrew/rubocops/cask/no_dsl_version.rb

This file was deleted.

1 change: 0 additions & 1 deletion Library/Homebrew/rubocops/rubocop-cask.rb
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
require_relative "cask/mixin/on_url_stanza"
require_relative "cask/desc"
require_relative "cask/homepage_url_trailing_slash"
require_relative "cask/no_dsl_version"
require_relative "cask/no_overrides"
require_relative "cask/on_system_conditionals"
require_relative "cask/stanza_order"
Expand Down
20 changes: 0 additions & 20 deletions Library/Homebrew/test/rubocops/cask/no_dsl_version_spec.rb

This file was deleted.