Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

audit: no longer need openssl/curl HTTP mirrors. #5626

Merged
merged 1 commit into from
Jan 27, 2019
Merged

audit: no longer need openssl/curl HTTP mirrors. #5626

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
13 changes: 1 addition & 12 deletions Library/Homebrew/dev-cmd/audit.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1122,20 +1122,9 @@ def self.curl_openssl_and_deps
end

def audit_urls
urls = [url] + mirrors

curl_openssl_or_deps = ResourceAuditor.curl_openssl_and_deps.include?(owner.name)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MikeMcQuaid curl_openssl_or_deps gets called in line 1137 and throws an undefined local variable or method error.


if spec_name == :stable && curl_openssl_or_deps
problem "should not use xz tarballs" if url.end_with?(".xz")

unless urls.find { |u| u.start_with?("http://") }
problem "should always include at least one HTTP mirror"
end
end

return unless @online

urls = [url] + mirrors
urls.each do |url|
next if !@strict && mirrors.include?(url)

Expand Down