Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add exception for veclibfort linking to Accelerate #6133

Merged
merged 2 commits into from May 14, 2019
Merged

Add exception for veclibfort linking to Accelerate #6133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b52e23c
Fix audit errors in dev-cmd/bump-revision.rb
zbeekman May 14, 2019
056a2d4
Add exception for veclibfort linking to Accelerate
zbeekman May 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions Library/Homebrew/dev-cmd/bump-revision.rb
View file
Open in desktop
Expand Up @@ -15,9 +15,9 @@ def bump_revision_args
present, "revision 1" will be added.
EOS
switch "-n", "--dry-run",
description: "Print what would be done rather than doing it."
description: "Print what would be done rather than doing it."
flag "--message=",
description: "Append the provided <message> to the default commit message."
description: "Append the provided <message> to the default commit message."

switch :force
switch :quiet
Expand Down Expand Up @@ -76,7 +76,7 @@ def bump_revision
else
formula.path.parent.cd do
safe_system "git", "commit", "--no-edit", "--verbose",
"--message=#{message}", "--", formula.path
"--message=#{message}", "--", formula.path
end
end
end
Expand Down
4 changes: 3 additions & 1 deletion Library/Homebrew/extend/os/mac/formula_cellar_checks.rb
View file
Open in desktop
Expand Up @@ -51,6 +51,7 @@ def check_openssl_links
def check_accelerate_framework_links
return unless @core_tap
return unless formula.prefix.directory?
return if formula.name == "veclibfort" # veclibfort exists to wrap accelerate

keg = Keg.new(formula.prefix)
system_accelerate = keg.mach_o_files.select do |obj|
Expand All @@ -63,7 +64,8 @@ def check_accelerate_framework_links
object files were linked against system Accelerate
These object files were linked against the outdated system Accelerate framework.
Core tap formulae should link against OpenBLAS instead.
Adding `depends_on "openblas"` to the formula may help.
Removing `depends_on "veclibfort" and/or adding `depends_on "openblas"` to the
formula may help.
#{system_accelerate * "\n "}
EOS
end
Expand Down