Skip to content

Add exception for veclibfort linking to Accelerate#6133

Merged
MikeMcQuaid merged 2 commits intoHomebrew:masterfrom
zbeekman:exception-for-veclibfort-accelerate-audit
May 14, 2019
Merged

Add exception for veclibfort linking to Accelerate#6133
MikeMcQuaid merged 2 commits intoHomebrew:masterfrom
zbeekman:exception-for-veclibfort-accelerate-audit

Conversation

@zbeekman
Copy link
Copy Markdown
Contributor

  • veclibfort exists solely to wrap Apple's accelerate and provide BLAS/LAPACK
    access to Accelerate

  • Improve the help message for that audit to mention veclibfort

  • See discussion in audit: check Accelerate linkage for core formulae #6130

  • Have you followed the guidelines in our Contributing document?

  • Have you checked to ensure there aren't other open Pull Requests for the same change?

  • Have you added an explanation of what your changes do and why you'd like us to include them?

Add an Accelerate linkage audit exception for veclibfort since its raison d'etre is to wrap accelerate.

  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@zbeekman
Copy link
Copy Markdown
Contributor Author

@MikeMcQuaid @jonchang no idea why the linux check is failing.

@MikeMcQuaid
Copy link
Copy Markdown
Member

@zbeekman Did you read the output? The reason seems pretty clear to me.

@zbeekman
Copy link
Copy Markdown
Contributor Author

@MikeMcQuaid Yup, read the output and saw that, however, I did NOT touch the file with the audit failure! I can look into fixing it, even though I didn't introduce the audit failure.

zbeekman added 2 commits May 14, 2019 12:03
 - Method alignment was bad across line break in 3 places.
 - veclibfort exists soley to wrap Apple's accelerate and provide BLAS/LAPACK
   access to Accelerate
 - Improve the help message for that audit to mention veclibfort
@zbeekman zbeekman force-pushed the exception-for-veclibfort-accelerate-audit branch from 0aabb50 to 056a2d4 Compare May 14, 2019 16:04
@MikeMcQuaid
Copy link
Copy Markdown
Member

@zbeekman Ok, I see now. I think it was a RuboCop bump happening before another PR was merged. Thanks for fixing it 🎉

@MikeMcQuaid MikeMcQuaid merged commit 24f5e69 into Homebrew:master May 14, 2019
@MikeMcQuaid
Copy link
Copy Markdown
Member

Thanks @zbeekman!

@zbeekman zbeekman deleted the exception-for-veclibfort-accelerate-audit branch June 4, 2019 20:16
@lock lock bot added the outdated PR was locked due to age label Jan 1, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants