Add exception for veclibfort linking to Accelerate#6133
Merged
MikeMcQuaid merged 2 commits intoHomebrew:masterfrom May 14, 2019
Merged
Add exception for veclibfort linking to Accelerate#6133MikeMcQuaid merged 2 commits intoHomebrew:masterfrom
MikeMcQuaid merged 2 commits intoHomebrew:masterfrom
Conversation
Contributor
Author
|
@MikeMcQuaid @jonchang no idea why the linux check is failing. |
Member
|
@zbeekman Did you read the output? The reason seems pretty clear to me. |
Contributor
Author
|
@MikeMcQuaid Yup, read the output and saw that, however, I did NOT touch the file with the audit failure! I can look into fixing it, even though I didn't introduce the audit failure. |
- Method alignment was bad across line break in 3 places.
- veclibfort exists soley to wrap Apple's accelerate and provide BLAS/LAPACK access to Accelerate - Improve the help message for that audit to mention veclibfort
0aabb50 to
056a2d4
Compare
Member
|
@zbeekman Ok, I see now. I think it was a RuboCop bump happening before another PR was merged. Thanks for fixing it 🎉 |
6 tasks
Member
|
Thanks @zbeekman! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
veclibfort exists solely to wrap Apple's accelerate and provide BLAS/LAPACK
access to Accelerate
Improve the help message for that audit to mention veclibfort
See discussion in audit: check Accelerate linkage for core formulae #6130
Have you followed the guidelines in our Contributing document?
Have you checked to ensure there aren't other open Pull Requests for the same change?
Have you added an explanation of what your changes do and why you'd like us to include them?
Add an Accelerate linkage audit exception for
veclibfortsince its raison d'etre is to wrap accelerate.brew stylewith your changes locally?brew testswith your changes locally?