Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: depends_on :linux is now the identifier for Linux-only formulae #7039

Merged
merged 1 commit into from Feb 16, 2020
Merged

docs: depends_on :linux is now the identifier for Linux-only formulae #7039

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 6 additions & 5 deletions docs/Homebrew-linuxbrew-core-Maintainer-Guide.md
View file
Open in desktop
Expand Up @@ -260,13 +260,14 @@ push a bottle commit to Homebrew/linuxbrew-core.

Make a PR to `Homebrew/linuxbrew-core` containing one commit named
like this: `name (new formula)`. Keep only one commit in this PR,
squash and force push to your branch if needed. Include a comment: `#
tag "linux"` in the formula after the `url` stanza, so maintainers can
easily find Linux only formulae.
squash and force push to your branch if needed. Include the line
`depends_on :linux` in the dependencies section, so that maintainers
can easily find Linux-only formulae.

For the bottle commit to be successful when new formulae are added, we
have to insert an empty bottle block into the formula code. This
usually goes after the `linux` tag.
usually goes after the `url` and `sha256` lines, with a blank line in
between.

```ruby
bottle do
Expand Down Expand Up @@ -351,7 +352,7 @@ correct repository:
### Linux-only formulae

If the formula is a Linux-only formula, it either:
- will contain the line `# tag "linux"`
- will contain the line `depends_on :linux`
- won't have macOS bottles

If the user hasn't used `brew bump-formula-pr`, or is submitting
Expand Down