Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace colon emojis #1601

Merged
merged 3 commits into from Oct 25, 2023
Merged

Replace colon emojis #1601

merged 3 commits into from Oct 25, 2023

Conversation

dnicolson
Copy link
Contributor

♻️ Current situation

Colon Markdown emojis are not parsed as they are on GitHub.

💡 Proposed solution

Restore the old directive from d2c5781#diff-61d17e6c4ec7de06b5ba2c5e7975a2bb0de868aa06f4453b53d9fc662d3d43fb, and apply the link and emoji behavior to all markdown elements.

Before and after:

@donavanbecker donavanbecker changed the base branch from latest to beta-4.51.1 October 25, 2023 19:29
bwp91
bwp91 approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@bwp91 bwp91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again!

@bwp91 bwp91 merged commit afe34a2 into homebridge:beta-4.51.1 Oct 25, 2023
22 checks passed
@NorthernMan54 NorthernMan54 mentioned this pull request Oct 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwp91 bwp91 bwp91 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dnicolson @bwp91 @donavanbecker