Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for https://github.com/homebridge/homebridge/issues/3453 #1602

Merged
merged 10 commits into from Oct 25, 2023

Conversation

NorthernMan54
Copy link
Contributor

@NorthernMan54 NorthernMan54 commented Oct 25, 2023

♻️ Current situation

Describe the current situation. Explain current problems, if there are any. Be as descriptive as possible (e.g., including examples or code snippets).

💡 Proposed solution

Describe the proposed solution and changes. How does it affect the project? How does it affect the internal structure (e.g., refactorings)?

⚙️ Release Notes

  • Blocks update-node from updating to version 20 on versions of Linux that don't support it and prevents this issue node: /usr/lib/arm-linux-gnueabihf/libstdc++.so.6: version 'GLIBCXX_3.4.26' not found (required by node) (#3453)
  • Fix for unable to update NodeSource based nodejs version (#1603)
  • Colon Markdown emojis are not parsed as they are on GitHub (#1601)
  • Prevent tooltip from displaying after Node.js modal (#1600)

➕ Additional Information

If applicable, provide additional context in this section.

Testing

Needs to be tested before releasing ( My test environment is currently down )

Reviewer Nudging

Where should the reviewer start? what is a good entry point?

@NorthernMan54 NorthernMan54 marked this pull request as draft October 25, 2023 14:05
@github-actions github-actions bot added the fix label Oct 25, 2023
@coveralls
Copy link

coveralls commented Oct 25, 2023

Pull Request Test Coverage Report for Build 6647343254

  • 0 of 4 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.05%) to 43.259%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/bin/platforms/linux.ts 0 4 0.0%
Totals Coverage Status
Change from base Build 6619424855: -0.05%
Covered Lines: 2111
Relevant Lines: 4515

💛 - Coveralls

bwp91
bwp91 previously approved these changes Oct 25, 2023
bwp91
bwp91 previously approved these changes Oct 25, 2023
@NorthernMan54 NorthernMan54 marked this pull request as ready for review October 25, 2023 23:04
@bwp91 bwp91 merged commit cdc0f25 into latest Oct 25, 2023
32 checks passed
@bwp91 bwp91 deleted the beta-4.51.1 branch October 25, 2023 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants