Breaking change identify event on PlatformAccessory

[ebaauw]

Describe The Bug:

The signature of the identify event from PlatformAccessory has changed. I think with the refactor of Homebridge to typescript.

The event used to be emitted as:

this.emit('identify', paired, callback);

but now it's:

homebridge/src/platformAccessory.ts

Line 85 in 736b3fa

this.emit(PlatformAccessoryEvent.IDENTIFY, () => {}); // empty callback for backwards compatibility

The paired parameter is missing.

This causes a TypeError for (dynamic platform) plugins calling the callback as second argument, see ebaauw/homebridge-zp#134.

To Reproduce:

Press ID in Eve, or pair the accessory in Home.

Expected behavior:

Backwards compatibility or explicitly documented as breaking change.

Environment:

• Node.js Version: v12.16.3
• NPM Version: v6.14.4
• Homebridge Version: v1.0.3

[Supereg]

Thanks for noticing, was corrected in cfe4d2e.

Is currently published as homebridge@1.0.5-beta.1.

If you want to keep backwards compatibility with your homebridge-lib plugin (for homebridge instances running a version < 1.0.0) you may want revert to still calling that callback.