Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix @scoped plugin registration to avoid warnings #2646

Merged
merged 3 commits into from
Aug 12, 2020
Merged

Fix @scoped plugin registration to avoid warnings #2646

merged 3 commits into from
Aug 12, 2020

Conversation

oznu
Copy link
Member

@oznu oznu commented Aug 12, 2020

This fixes warnings such as:

A platform configure a new accessory under the plugin name '@oznu/homebridge-plugin-name'. However no loaded plugin could be found for the name!

and:

When searching for the associated plugin of the accessory 'Wifi fan' it seems like the plugin name changed from '@milo526/homebridge-tuya-web' to '@milo526/homebridge-tuya-web'. Plugin association is now being transformed!

@oznu oznu requested a review from Supereg August 12, 2020 12:29
@milo526 milo526 mentioned this pull request Aug 12, 2020
Closed
Supereg
Supereg approved these changes Aug 12, 2020
View reviewed changes
src/pluginManager.ts Outdated Show resolved Hide resolved
@oznu oznu merged commit da6e7bf into master Aug 12, 2020
@oznu oznu deleted the bugfix/scoped-plugin-registration branch August 12, 2020 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Supereg Supereg Supereg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@oznu @Supereg