Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

latest <- beta #3510

Merged
merged 15 commits into from Apr 19, 2024
Merged

latest <- beta #3510

merged 15 commits into from Apr 19, 2024

Conversation

bwp91
Copy link
Contributor

@bwp91 bwp91 commented Dec 9, 2023 •
edited

For a v1.8.0 release

Added

  • allow for FirmwareRevision override in config
  • add GitHub labeler action
  • allow custom NODE_OPTIONS and DEBUG on child bridges
  • add logging success colour (add logging success colour #3581)
  • adds alpha publisher

Changed

  • improve README installation docs
  • updated dependencies
  • updated Discord Webhooks so notifications are seperated for release and pre-release
  • updated lint rules for imports
  • regenerate docs
  • update hap-nodejs version

Homebridge Dependencies

  • hap-nodejs @ v0.12.0

@github-actions github-actions bot added the latest label Dec 9, 2023
@coveralls
Copy link

coveralls commented Dec 9, 2023 •
edited

Pull Request Test Coverage Report for Build 8758682048

Details

  • 42 of 61 (68.85%) changed or added relevant lines in 12 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+2.2%) to 28.024%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/plugin.ts 3 4 75.0%
src/server.ts 8 9 88.89%
src/childBridgeService.ts 4 9 44.44%
src/childBridgeFork.ts 0 6 0.0%
src/cli.ts 0 6 0.0%
Files with Coverage Reduction New Missed Lines %
src/childBridgeService.ts 1 9.66%
src/childBridgeFork.ts 1 0.0%
Totals Coverage Status
Change from base Build 8517865881: 2.2%
Covered Lines: 426
Relevant Lines: 1373
💛 - Coveralls

@donavanbecker donavanbecker force-pushed the beta-1.7.1 branch 3 times, most recently from 72d7fa1 to c5946c5 Compare December 9, 2023 07:54
@bwp91 bwp91 changed the title [do not merge] latest <- beta latest <- beta Dec 9, 2023
@bwp91 bwp91 marked this pull request as draft December 9, 2023 18:33
@bwp91 bwp91 marked this pull request as ready for review December 28, 2023 03:56
donavanbecker
donavanbecker previously approved these changes Dec 28, 2023
View reviewed changes
Copy link
Contributor

@donavanbecker donavanbecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I say v1.7.1

@donavanbecker donavanbecker force-pushed the beta-1.7.1 branch 2 times, most recently from 25801fe to c360634 Compare December 29, 2023 16:44
@donavanbecker
Discord Webhooks
3b8f0da 
Separate prereleases and releases for Discord Webhooks
@bwp91
Copy link
Contributor Author

bwp91 commented Mar 17, 2024

Hi @Supereg

Fancy having a look at this at some point and let me know of any comments/concerns you can see?

Ta!

Supereg
Supereg previously approved these changes Mar 17, 2024
View reviewed changes
Copy link
Member

@Supereg Supereg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks for fixing all the spelling and grammar issues 🚀

Just had some small comments here and there 👍

.github/workflows/release-drafter.yml Show resolved Hide resolved
README.md Show resolved Hide resolved
package.json Show resolved Hide resolved
Supereg
Supereg reviewed Mar 17, 2024
View reviewed changes
package.json Show resolved Hide resolved
NorthernMan54
NorthernMan54 previously approved these changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@NorthernMan54 NorthernMan54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@bwp91 bwp91 dismissed stale reviews from NorthernMan54 and Supereg via 8a8eac3 March 24, 2024 18:17
@bwp91 bwp91 requested a review from Supereg April 1, 2024 22:13
Supereg
Supereg previously approved these changes Apr 2, 2024
View reviewed changes
@bwp91 bwp91 merged commit f8c78ea into latest Apr 19, 2024
13 checks passed
@bwp91 bwp91 deleted the beta-1.7.1 branch April 19, 2024 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Supereg Supereg Supereg approved these changes

@NorthernMan54 NorthernMan54 Awaiting requested review from NorthernMan54

@donavanbecker donavanbecker Awaiting requested review from donavanbecker

Assignees
No one assigned
Labels
latest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@bwp91 @coveralls @Supereg @donavanbecker @NorthernMan54