Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add logging success colour #3581

Merged
merged 2 commits into from Mar 24, 2024
Merged

add logging success colour #3581

merged 2 commits into from Mar 24, 2024

Conversation

bwp91
Copy link
Contributor

@bwp91 bwp91 commented Mar 23, 2024

I have been thinking about doing this for a while - adding a 'green' logging colour available to plugins to highlight successful actions that might otherwise be missed if white and in the middle of another plugin's spam.

What do you guys think?

@coveralls
Copy link

coveralls commented Mar 23, 2024

Pull Request Test Coverage Report for Build 8401549560

Details

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+2.3%) to 28.194%

Totals Coverage Status
Change from base Build 8308190422: 2.3%
Covered Lines: 426
Relevant Lines: 1370

💛 - Coveralls

Copy link
Member

@Supereg Supereg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like a cool idea, happy to have it merged.

Just one thing, as you are trying to merge this into the 1.7.1 beta branch. I would consider this to be part of a minor release, so should we aim for a 1.8.0 beta here?

src/logger.spec.ts Show resolved Hide resolved
src/logger.ts Show resolved Hide resolved
@bwp91
Copy link
Contributor Author

bwp91 commented Mar 24, 2024

I was thinking to merge this into the beta-1.7.1 branch but when we end up releasing the new version it should be bumped to 1.8.0.

@Supereg
Copy link
Member

Supereg commented Mar 24, 2024

I was thinking to merge this into the beta-1.7.1 branch but when we end up releasing the new version it should be bumped to 1.8.0.

Sounds good 👍

@bwp91 bwp91 merged commit 8a8eac3 into beta-1.7.1 Mar 24, 2024
8 checks passed
@bwp91 bwp91 deleted the bp/add-success-logging branch March 24, 2024 18:17
@bwp91 bwp91 mentioned this pull request Apr 1, 2024
bwp91 added a commit that referenced this pull request Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants