Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

homebridge-level-sense #530

Closed
waltmoorhouse opened this issue Apr 9, 2023 · 3 comments
Closed

homebridge-level-sense #530

waltmoorhouse opened this issue Apr 9, 2023 · 3 comments
Labels
verified use when a plugin meets the criteria - adds the verified badge text

Comments

@waltmoorhouse
Copy link

Link To GitHub Repo

https://github.com/waltmoorhouse/homebridge-level-sense

Link To NPM Package

https://www.npmjs.com/package/homebridge-level-sense

@waltmoorhouse waltmoorhouse added the pending the label given to a new verification/icon request label Apr 9, 2023
@github-actions
Copy link

github-actions bot commented Apr 9, 2023

✅ Pre-checks completed successfully.

@bwp91
Copy link
Contributor

bwp91 commented Apr 12, 2023

Hi @waltmoorhouse

My comments here would be the same as the other plugin #529

  1. about the name property in the config schema file
  2. this is most likely a very picky comment (so sorry!) but I noticed in the log when I configured incorrect credentials
    [12/04/2023, 22:35:36] [homebridge-level-sense] ERROR: unable to fetch devices - Please provide session key
    [12/04/2023, 22:35:36] [homebridge-level-sense] Updating device readings.
    [12/04/2023, 22:35:36] [homebridge-level-sense] Discovery action completed
    
    i just wondered whether there is some unnecessary interval going on that could be removed in the case that the plugin has never been able to set up properly.

otherwise all seems good to happy to verify 😁

@bwp91
Copy link
Contributor

bwp91 commented Apr 12, 2023

Congratulations! Your plugin has been verified.

You can now add the Verified by Homebridge badge to your plugin's README:

verified-by-homebridge

[![verified-by-homebridge](https://badgen.net/badge/homebridge/verified/purple)](https://github.com/homebridge/homebridge/wiki/Verified-Plugins)

Your plugin is now also eligible to display a ❤️ Donate button on its tile in the Homebridge UI. See https://github.com/oznu/homebridge-config-ui-x/wiki/Developers:-Donation-Links for instructions.

If for any reason in the future you can no longer maintain your plugin, please consider transferring it to our unmaintained plugins repo. We can take ownership until another willing developer comes along.

Thank you for your contribution to the Homebridge Community.
https://homebridge.io

@bwp91 bwp91 added verified use when a plugin meets the criteria - adds the verified badge text and removed pending the label given to a new verification/icon request labels Apr 12, 2023
@bwp91 bwp91 closed this as completed Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
verified use when a plugin meets the criteria - adds the verified badge text
Projects
None yet
Development

No branches or pull requests

2 participants