[T] Upgrade vue-test-utils #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viniciuskneves
requested review from
aym3nb,
drapisarda,
ilyasmez,
leandroinacio,
metal-gogo,
mlande,
SinisaG and
volcanioo
as code owners
|
Yes, coverage dropped =] I can work on improving it in another PR if you agree. |
Merged
aym3nb
reviewed
Apr 8, 2020
aym3nb
approved these changes
Apr 8, 2020
ilyasmez
approved these changes
Apr 8, 2020
metal-gogo
reviewed
Apr 8, 2020
|
@homeday-de/frontend-engineering May I proceed here? |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses: #232
I do also recommend you to read the official changelogs: https://github.com/vuejs/vue-test-utils/releases
All in all it tackles the following breaking change: vuejs/vue-test-utils#1137
I've also removed some tests, refactored others and cleaned up a bit.
I've also introduced the same
wrapperFactoryBuilderthat we're using in Realtor App. Its API maps tomount/shallowMountand instead of usingpropsDatayou just useprops. I'm creating the wrapper inside each test to avoid callingawait wrapper.vm.$nextTick()a lot of times.