Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the inspect mode, update dependencies and refactor the watch mode flag #13

Merged
merged 3 commits into from Aug 15, 2018

Conversation

homer0
Copy link
Owner

@homer0 homer0 commented Aug 15, 2018

What does this PR do?

On homer0/projext#56 I added the inspect mode, so Node targets can be executed with the Node inspector or Google's ndb. This pull request is the implementation for Rollup.

While I was implementing it, I decided to change the way the watch option was being handled: instead of using an extra parameter everywhere, I applied the same approach as for the forceRun, if the flag is enabled, change the setting on the target object. (This change is what makes this PR breaking).

I also updated all the project production and development dependencies to their latest versions.

How should it be tested manually?

You first need projext#next installed, then try using the new projext inspect command for a bundled target.

And of course...

npm test
# or
yarn test

@coveralls
Copy link

Pull Request Test Coverage Report for Build 45

  • 20 of 20 (100.0%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 43: 0.0%
Covered Lines: 1344
Relevant Lines: 1344

💛 - Coveralls

@homer0 homer0 merged commit b2edf49 into next Aug 15, 2018
@homer0 homer0 deleted the homer0_inspect branch August 15, 2018 09:01
@homer0 homer0 added the on:next label Aug 15, 2018
This was referenced Aug 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants