Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inspect mode #56

Merged
merged 3 commits into from
Aug 14, 2018
Merged

Inspect mode #56

merged 3 commits into from
Aug 14, 2018

Conversation

homer0
Copy link
Owner

@homer0 homer0 commented Aug 14, 2018

What does this PR do?

It finally brings the option to use the Node inspector for Node targets.

The feature description is on the documents, so you can get it from there; instead, I'll try to describe the code changes:

  • Node targets now have an inspect settings group to configure the inspector and enable it for when the target runs on development.
  • The node runner was updated to support both the native inspector and the new Google's ndb.
  • The build command now can receive an --inspect flag.
  • There's a new inspect command, which is a shortcut of build --run --inspect.
  • nodemon is not longer executed with a settings object but with a string, to add support for the native inspector inspect flag.
  • While reading the nodemon documentation, I saw the --legacy-watch, so I implemented it as a project configuration on the others category.

And this is breaking because...

  • BuildNodeRunner now requires projectConfiguration (to get the legacy watch setting).
  • buildNodeRunnerProcess is not longer BuildNodeRunnerProcess#run, but the class instance itself, because BuildNodeRunner needed access to the enableLegacyWatch method.
  • BuildNodeRunnerProcess#run now requires a new parameter with the inspect options.

How should it be tested manually?

Since the webpack and Rollup plugins haven't been updated (yet), you can only test this with targets that don't require bundling:

yarn projext inspect [target]

and of course...

npm test
# or
yarn test

@coveralls
Copy link

Pull Request Test Coverage Report for Build 199

  • 85 of 85 (100.0%) changed or added relevant lines in 14 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 196: 0.0%
Covered Lines: 1908
Relevant Lines: 1908

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants