Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It finally brings the option to use the Node inspector for Node targets.
The feature description is on the documents, so you can get it from there; instead, I'll try to describe the code changes:
inspect
settings group to configure the inspector and enable it for when the target runs on development.--inspect
flag.inspect
command, which is a shortcut ofbuild --run --inspect
.nodemon
is not longer executed with a settings object but with a string, to add support for the native inspectorinspect
flag.nodemon
documentation, I saw the--legacy-watch
, so I implemented it as a project configuration on theothers
category.And this is breaking because...
BuildNodeRunner
now requiresprojectConfiguration
(to get the legacy watch setting).buildNodeRunnerProcess
is not longerBuildNodeRunnerProcess#run
, but the class instance itself, becauseBuildNodeRunner
needed access to theenableLegacyWatch
method.BuildNodeRunnerProcess#run
now requires a new parameter with the inspect options.How should it be tested manually?
Since the webpack and Rollup plugins haven't been updated (yet), you can only test this with targets that don't require bundling:
and of course...