Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(services/configurations): use terser instead of uglify #38

Merged
merged 2 commits into from
Aug 26, 2019

Conversation

homer0
Copy link
Owner

@homer0 homer0 commented Aug 26, 2019

What does this PR do?

This is something I already did for the webpack plugin on homer0/projext-plugin-webpack#63 and I didn't do it here because I was sure the uglify plugin was already using terser...well, it wasn't.

The problem is that uglifyjs can't handle ES6+ code, so if you want to uglify that kind of code, you need to use terser.

I replaced rollup-plugin-uglify with rollup-plugin-terser and, the change that makes this breaking, I updated all the events settings for the new plugin:

- rollup-uglify-plugin-settings-configuration-for-node
+ rollup-terser-plugin-settings-configuration-for-node

- rollup-uglify-plugin-settings-configuration-for-browser
+ rollup-terser-plugin-settings-configuration-for-browser

- rollup-uglify-plugin-settings-configuration
+ rollup-terser-plugin-settings-configuration

How should it be tested manually?

Try to build a project with ES6 code for production (to trigger the uglify process), and of course...

yarn test
# or
npm test

@coveralls
Copy link

coveralls commented Aug 26, 2019

Pull Request Test Coverage Report for Build 132

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 131: 0.0%
Covered Lines: 1479
Relevant Lines: 1479

💛 - Coveralls

@homer0 homer0 merged commit 59b6561 into next Aug 26, 2019
@homer0 homer0 deleted the homer0_terser branch August 26, 2019 10:33
@homer0 homer0 added the on:next label Aug 26, 2019
@homer0 homer0 mentioned this pull request Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants