Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(configurations/browser/production): replace uglify with terser #63

Merged
merged 2 commits into from
Apr 25, 2019

Conversation

homer0
Copy link
Owner

@homer0 homer0 commented Apr 24, 2019

What does this PR do?

It replaces uglifyjs-webpack-plugin with terser-webpack-plugin for bundle minification/uglification. The main reason is that uglifyjs doesn't support ES6+ code, and in the future, webpack will include terser as its default minification "engine".

Also, instead of adding terser to the plugins list, I'm adding it on the new optimization object, like the webpack documentation recommends.

This is breaking for plugin developers and in case you are using events to modify the configuration.

How should it be tested manually?

For an end user that is not modifying the configuration, the change is not breaking, so just install the branch and build for production, the minification should happen the same way as before.

And of course...

yarn test
# or
npm test

@coveralls
Copy link

coveralls commented Apr 24, 2019

Pull Request Test Coverage Report for Build 230

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 228: 0.0%
Covered Lines: 591
Relevant Lines: 591

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants