Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Babel dependencies #62

Merged
merged 1 commit into from
Feb 5, 2019
Merged

Update Babel dependencies #62

merged 1 commit into from
Feb 5, 2019

Conversation

homer0
Copy link
Owner

@homer0 homer0 commented Feb 5, 2019

What does this PR do?

We are finally moving from Babel 6 to 7! So the big change on this PR is that everything Babel related now uses their "new" namespace: @babel/.

This is breaking because of two reasons:

  1. If you have some custom plugin or something adding settings Babel configuration (or the env preset, like the Angular and React plugins), you need to update them to use the new name: @babel/preset-env.
  2. If you added custom plugins or preset to your target Babel configuration, they now need to be compatible with Babel > 7, so they need to be on @babel/ (at least the officials).

How should it be tested manually?

  1. Try enabling decorators or properties to your target and make sure they still work as expected.
  2. And....
yarn test
# or
npm test

Don't try the other projext plugins yet as they are currently being updated too.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 221

  • 6 of 6 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 219: 0.0%
Covered Lines: 2028
Relevant Lines: 2028

💛 - Coveralls

@homer0 homer0 merged commit 85b103d into next Feb 5, 2019
@homer0 homer0 deleted the homer0_updateBabel branch February 5, 2019 02:57
@homer0 homer0 added the on:next label Feb 5, 2019
@homer0 homer0 mentioned this pull request Feb 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants