Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(project): require Node > 8.10 #81

Merged
merged 2 commits into from
Jul 31, 2019
Merged

refactor(project): require Node > 8.10 #81

merged 2 commits into from
Jul 31, 2019

Conversation

homer0
Copy link
Owner

@homer0 homer0 commented Jul 31, 2019

What does this PR do?

It updates the required version of Node to > 8.10. The reason for this is that a few "main dependencies" for the build engines now have the same requirement, and it order to keep updating them (to prevent vulnerabilities) I had to apply the same restriction.

I also fixed a typo in one of the documents :P.

How should it be tested manually?

Update the Node version, install the dependencies and...

yarn test
# or
npm test

@coveralls
Copy link

Pull Request Test Coverage Report for Build 288

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 285: 0.0%
Covered Lines: 2194
Relevant Lines: 2194

💛 - Coveralls

@homer0 homer0 changed the base branch from homer0_dotenv to next July 31, 2019 08:37
@homer0 homer0 merged commit 5c37405 into next Jul 31, 2019
@homer0 homer0 deleted the homer0_nodeUpdate branch July 31, 2019 08:38
@homer0 homer0 added the on:next label Jul 31, 2019
@homer0 homer0 mentioned this pull request Jul 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants